Re: [Qemu-devel] [PATCH v2] block: Remove "options" indirection from blockdev-add

2016-10-11 Thread Markus Armbruster
Kevin Wolf writes: > Now that QAPI supports boxed types, we can have unions at the top level > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains the > real arguments. > > blockdev-add is still

Re: [Qemu-devel] [PATCH v2] block: Remove "options" indirection from blockdev-add

2016-10-10 Thread Eric Blake
On 10/10/2016 08:41 AM, Kevin Wolf wrote: > Now that QAPI supports boxed types, we can have unions at the top level > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains the > real arguments. > > blockdev-add is

Re: [Qemu-devel] [PATCH v2] block: Remove "options" indirection from blockdev-add

2016-10-10 Thread Max Reitz
On 10.10.2016 15:41, Kevin Wolf wrote: > Now that QAPI supports boxed types, we can have unions at the top level > of a command, so let's put our real options directly there for > blockdev-add instead of having a single "options" dict that contains the > real arguments. > > blockdev-add is still

[Qemu-devel] [PATCH v2] block: Remove "options" indirection from blockdev-add

2016-10-10 Thread Kevin Wolf
Now that QAPI supports boxed types, we can have unions at the top level of a command, so let's put our real options directly there for blockdev-add instead of having a single "options" dict that contains the real arguments. blockdev-add is still experimental and we already made substantial