Re: [Qemu-devel] [PATCH v2 0/5] Make rt_clock usage configurable for ARM devices
Il 05/03/2012 15:05, Peter Maydell ha scritto: On 5 March 2012 09:08, Paolo Bonzini pbonz...@redhat.com wrote: Direct usage of rt_clock should be discouraged. For RTC devices the user cannot choose to follow the host clock with respect to NTP adjustment and daylight savings changes. For other devices it does not provide determinism together with -icount or qtest, and it also keeps ticking while the machine is paused. This series uses rtc_clock uniformly in device models that provide RTC functionality, and vm_clock in the omap_lpg whose ticking should be tied to the VM running state. For consistency I'm also switching the pl031 to rtc_clock; so far it used the vm_clock. v1-v2: switch omap_lpg to vm_clock Paolo Bonzini (5): rtc: add -rtc clock=rt omap: switch omap_lpg to vm_clock arm: switch real-time clocks to rtc_clock pl031: rearm alarm timer upon load pl031: switch clock base to rtc_clock I'm happy to take these into the arm-devs tree, but I'd prefer to see an ack or review from somebody who understands qemu timers first. Two weeks passed... prefer or require? :) Paolo
Re: [Qemu-devel] [PATCH v2 0/5] Make rt_clock usage configurable for ARM devices
On 27 March 2012 18:07, Paolo Bonzini pbonz...@redhat.com wrote: Il 05/03/2012 15:05, Peter Maydell ha scritto: On 5 March 2012 09:08, Paolo Bonzini pbonz...@redhat.com wrote: Paolo Bonzini (5): rtc: add -rtc clock=rt omap: switch omap_lpg to vm_clock arm: switch real-time clocks to rtc_clock pl031: rearm alarm timer upon load pl031: switch clock base to rtc_clock I'm happy to take these into the arm-devs tree, but I'd prefer to see an ack or review from somebody who understands qemu timers first. Two weeks passed... prefer or require? :) Yeah, I was just thinking I should probably give in and take these unreviewed... (shame there's no tag for signed-off-by but not reviewed-by :-)) -- PMM
Re: [Qemu-devel] [PATCH v2 0/5] Make rt_clock usage configurable for ARM devices
Il 05/03/2012 15:05, Peter Maydell ha scritto: Direct usage of rt_clock should be discouraged. For RTC devices the user cannot choose to follow the host clock with respect to NTP adjustment and daylight savings changes. For other devices it does not provide determinism together with -icount or qtest, and it also keeps ticking while the machine is paused. This series uses rtc_clock uniformly in device models that provide RTC functionality, and vm_clock in the omap_lpg whose ticking should be tied to the VM running state. For consistency I'm also switching the pl031 to rtc_clock; so far it used the vm_clock. v1-v2: switch omap_lpg to vm_clock Paolo Bonzini (5): rtc: add -rtc clock=rt omap: switch omap_lpg to vm_clock arm: switch real-time clocks to rtc_clock pl031: rearm alarm timer upon load pl031: switch clock base to rtc_clock I'm happy to take these into the arm-devs tree, but I'd prefer to see an ack or review from somebody who understands qemu timers first. Andrzej or Jan, would you take a look? Paolo
[Qemu-devel] [PATCH v2 0/5] Make rt_clock usage configurable for ARM devices
Direct usage of rt_clock should be discouraged. For RTC devices the user cannot choose to follow the host clock with respect to NTP adjustment and daylight savings changes. For other devices it does not provide determinism together with -icount or qtest, and it also keeps ticking while the machine is paused. This series uses rtc_clock uniformly in device models that provide RTC functionality, and vm_clock in the omap_lpg whose ticking should be tied to the VM running state. For consistency I'm also switching the pl031 to rtc_clock; so far it used the vm_clock. v1-v2: switch omap_lpg to vm_clock Paolo Bonzini (5): rtc: add -rtc clock=rt omap: switch omap_lpg to vm_clock arm: switch real-time clocks to rtc_clock pl031: rearm alarm timer upon load pl031: switch clock base to rtc_clock hw/omap1.c | 10 +++--- hw/pl031.c | 75 --- hw/pxa2xx.c | 28 ++-- hw/strongarm.c | 10 +++--- hw/twl92230.c |9 +++--- qemu-options.hx |7 +++-- vl.c|2 + 7 files changed, 84 insertions(+), 57 deletions(-) -- 1.7.7.6
Re: [Qemu-devel] [PATCH v2 0/5] Make rt_clock usage configurable for ARM devices
On 5 March 2012 09:08, Paolo Bonzini pbonz...@redhat.com wrote: Direct usage of rt_clock should be discouraged. For RTC devices the user cannot choose to follow the host clock with respect to NTP adjustment and daylight savings changes. For other devices it does not provide determinism together with -icount or qtest, and it also keeps ticking while the machine is paused. This series uses rtc_clock uniformly in device models that provide RTC functionality, and vm_clock in the omap_lpg whose ticking should be tied to the VM running state. For consistency I'm also switching the pl031 to rtc_clock; so far it used the vm_clock. v1-v2: switch omap_lpg to vm_clock Paolo Bonzini (5): rtc: add -rtc clock=rt omap: switch omap_lpg to vm_clock arm: switch real-time clocks to rtc_clock pl031: rearm alarm timer upon load pl031: switch clock base to rtc_clock I'm happy to take these into the arm-devs tree, but I'd prefer to see an ack or review from somebody who understands qemu timers first. -- PMM
