Re: [Qemu-devel] [PATCH v2 05/11] qemu-iotests/087: Avoid blockdev-add with id

2016-09-20 Thread Eric Blake
On 09/20/2016 08:03 AM, Kevin Wolf wrote:
> We want to remove the 'id' option for blockdev-add. This removes one
> user of the option and makes it use only node names.
> 
> The test cases that test conflicts between the 'id' option to
> blockdev-add and existing block devices or the 'node-name' of the same
> command can be removed because it won't be possible to specify this at
> the end of the series.
> 
> Signed-off-by: Kevin Wolf 
> ---
>  tests/qemu-iotests/087 | 62 
> --
>  tests/qemu-iotests/087.out |  6 +
>  2 files changed, 6 insertions(+), 62 deletions(-)
> 

Reviewed-by: Eric Blake 

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature


[Qemu-devel] [PATCH v2 05/11] qemu-iotests/087: Avoid blockdev-add with id

2016-09-20 Thread Kevin Wolf
We want to remove the 'id' option for blockdev-add. This removes one
user of the option and makes it use only node names.

The test cases that test conflicts between the 'id' option to
blockdev-add and existing block devices or the 'node-name' of the same
command can be removed because it won't be possible to specify this at
the end of the series.

Signed-off-by: Kevin Wolf 
---
 tests/qemu-iotests/087 | 62 --
 tests/qemu-iotests/087.out |  6 +
 2 files changed, 6 insertions(+), 62 deletions(-)

diff --git a/tests/qemu-iotests/087 b/tests/qemu-iotests/087
index e7bca37..5c04577 100755
--- a/tests/qemu-iotests/087
+++ b/tests/qemu-iotests/087
@@ -77,50 +77,12 @@ echo
 echo === Duplicate ID ===
 echo
 
-run_qemu <