Re: [Qemu-devel] [PATCH v2 1/3] iotests: Add 241 to test NBD on unaligned images

2019-03-29 Thread Eric Blake
On 3/29/19 2:58 AM, Kevin Wolf wrote: +seq="$(basename $0)" +echo "QA output created by $seq" + +status=1 # failure is the default! + +nbd_unix_socket=$TEST_DIR/test_qemu_nbd_socket +rm -f "${TEST_DIR}/qemu-nbd.pid" >>> >>> hmm, strange that we need to remove

Re: [Qemu-devel] [PATCH v2 1/3] iotests: Add 241 to test NBD on unaligned images

2019-03-29 Thread Kevin Wolf
Am 28.03.2019 um 19:27 hat Eric Blake geschrieben: > On 3/28/19 3:20 AM, Vladimir Sementsov-Ogievskiy wrote: > > 28.03.2019 1:39, Eric Blake wrote: > >> Add a test for the NBD client workaround in the previous patch. It's > >> not really feasible for an iotest to assume a specific tracing engine,

Re: [Qemu-devel] [PATCH v2 1/3] iotests: Add 241 to test NBD on unaligned images

2019-03-28 Thread Eric Blake
On 3/28/19 3:20 AM, Vladimir Sementsov-Ogievskiy wrote: > 28.03.2019 1:39, Eric Blake wrote: >> Add a test for the NBD client workaround in the previous patch. It's >> not really feasible for an iotest to assume a specific tracing engine, >> so we can't really probe for the new >>

Re: [Qemu-devel] [PATCH v2 1/3] iotests: Add 241 to test NBD on unaligned images

2019-03-28 Thread Vladimir Sementsov-Ogievskiy
28.03.2019 1:39, Eric Blake wrote: > Add a test for the NBD client workaround in the previous patch. It's > not really feasible for an iotest to assume a specific tracing engine, > so we can't really probe for the new > trace_nbd_parse_blockstatus_compliance to see if the server was fixed > vs.

[Qemu-devel] [PATCH v2 1/3] iotests: Add 241 to test NBD on unaligned images

2019-03-27 Thread Eric Blake
Add a test for the NBD client workaround in the previous patch. It's not really feasible for an iotest to assume a specific tracing engine, so we can't really probe for the new trace_nbd_parse_blockstatus_compliance to see if the server was fixed vs. whether the client just worked around the