Re: [Qemu-devel] [PATCH v2 1/3] qmp: fix object-add assert() without props

2016-09-22 Thread Eric Blake
On 09/22/2016 08:09 AM, Marc-André Lureau wrote: > Since commit ad739706bbadee49, user_creatable_add_type() expects to be > given a qdict. However, if object-add is called without props, you reach > the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type: > Assertion `qdict'

[Qemu-devel] [PATCH v2 1/3] qmp: fix object-add assert() without props

2016-09-22 Thread Marc-André Lureau
Since commit ad739706bbadee49, user_creatable_add_type() expects to be given a qdict. However, if object-add is called without props, you reach the assert: "qemu/qom/object_interfaces.c:115: user_creatable_add_type: Assertion `qdict' failed.", because the qdict isn't created in this case (it's