Re: [Qemu-devel] [PATCH v2 1/7] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap

On 04/16/2018 07:44 AM, Vladimir Sementsov-Ogievskiy wrote: > Functions write to BdrvDirtyBitmap field, so the should take the lock. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Looks like this won't introduce any recursive locking that I can spot, so this looks correct. Reviewed-by: John

[Qemu-devel] [PATCH v2 1/7] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap

Functions write to BdrvDirtyBitmap field, so the should take the lock. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 4 1 file changed, 4 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 967159479d..6c00288fd7 100644 --- a/block/dirty-bi