Re: [Qemu-devel] [PATCH v2 2/9] tcg/optimize: move default return out of if statement

[Richard Henderson]

On 09/22/2016 03:13 AM, Alex Bennée wrote:

This is to appease sanitizer builds which complain that:

  "error: control reaches end of non-void function"

Signed-off-by: Alex Bennée 
Reviewed-by: Marc-André Lureau 
---
 tcg/optimize.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index 9998ac7..0f13490 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -468,9 +468,8 @@ static TCGArg do_constant_folding_cond(TCGOpcode op, TCGArg 
x,
 default:
 return 2;
 }
-} else {
-return 2;
 }
+return 2;


I'm disappointed that the sanitizer doesn't see the abort above as a noreturn. 
That said, this isn't wrong so,


Reviewed-by: Richard Henderson 


r~

[Qemu-devel] [PATCH v2 2/9] tcg/optimize: move default return out of if statement

[Alex Bennée]

This is to appease sanitizer builds which complain that:

  "error: control reaches end of non-void function"

Signed-off-by: Alex Bennée 
Reviewed-by: Marc-André Lureau 
---
 tcg/optimize.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index 9998ac7..0f13490 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -468,9 +468,8 @@ static TCGArg do_constant_folding_cond(TCGOpcode op, TCGArg 
x,
 default:
 return 2;
 }
-} else {
-return 2;
 }
+return 2;
 }
 
 /* Return 2 if the condition can't be simplified, and the result
-- 
2.9.3