Re: [Qemu-devel] [PATCH v2 3/3] block/iscsi: fix ioctl cancel use-after-free

2018-02-14 Thread Felipe Franciosi
> On 3 Feb 2018, at 06:16, Stefan Hajnoczi wrote: > > iscsi_aio_cancel() does not increment the request's reference count, > causing a use-after-free when ABORT TASK finishes after the request has > already completed. > > There are some additional issues with iscsi_aio_cancel(): > 1. Several AB

Re: [Qemu-devel] [PATCH v2 3/3] block/iscsi: fix ioctl cancel use-after-free

2018-02-13 Thread Stefan Hajnoczi
On Fri, Feb 09, 2018 at 06:50:06PM +0100, Paolo Bonzini wrote: > On 03/02/2018 07:16, Stefan Hajnoczi wrote: > > iscsi_aio_cancel() does not increment the request's reference count, > > causing a use-after-free when ABORT TASK finishes after the request has > > already completed. > > > > There are

Re: [Qemu-devel] [PATCH v2 3/3] block/iscsi: fix ioctl cancel use-after-free

2018-02-09 Thread Paolo Bonzini
On 03/02/2018 07:16, Stefan Hajnoczi wrote: > iscsi_aio_cancel() does not increment the request's reference count, > causing a use-after-free when ABORT TASK finishes after the request has > already completed. > > There are some additional issues with iscsi_aio_cancel(): > 1. Several ABORT TASKs m

[Qemu-devel] [PATCH v2 3/3] block/iscsi: fix ioctl cancel use-after-free

2018-02-02 Thread Stefan Hajnoczi
iscsi_aio_cancel() does not increment the request's reference count, causing a use-after-free when ABORT TASK finishes after the request has already completed. There are some additional issues with iscsi_aio_cancel(): 1. Several ABORT TASKs may be sent for the same task if iscsi_aio_cancel() is