Re: [Qemu-devel] [PATCH v2 3/3] block/qcow2: proper locking on bitmap add/remove paths

2019-09-13 Thread John Snow
On 9/11/19 11:00 AM, Vladimir Sementsov-Ogievskiy wrote: > qmp_block_dirty_bitmap_add and do_block_dirty_bitmap_remove do acquire > aio context since 0a6c86d024c52b. But this is not enough: we also must > lock qcow2 mutex when access in-image metadata. Especially it concerns > freeing qcow2 clus

[Qemu-devel] [PATCH v2 3/3] block/qcow2: proper locking on bitmap add/remove paths

2019-09-11 Thread Vladimir Sementsov-Ogievskiy
qmp_block_dirty_bitmap_add and do_block_dirty_bitmap_remove do acquire aio context since 0a6c86d024c52b. But this is not enough: we also must lock qcow2 mutex when access in-image metadata. Especially it concerns freeing qcow2 clusters. To achieve this, move qcow2_can_store_new_dirty_bitmap and qc