Re: [Qemu-devel] [PATCH v3 1/1] dump.c: allow fd_write_vmcore to return errno on failure

2018-02-12 Thread Murilo Opsfelder Araujo
On 02/12/2018 03:31 PM, Eric Blake wrote: > On 02/12/2018 08:46 AM, Murilo Opsfelder Araujo wrote: >> On 02/12/2018 12:25 PM, Daniel Henrique Barboza wrote: >>> From: Yasmin Beatriz >>> >>> fd_write_vmcore can fail to execute for a lot of reasons that can be >>> retrieved by errno, but it only ret

Re: [Qemu-devel] [PATCH v3 1/1] dump.c: allow fd_write_vmcore to return errno on failure

2018-02-12 Thread Eric Blake
On 02/12/2018 08:25 AM, Daniel Henrique Barboza wrote: From: Yasmin Beatriz fd_write_vmcore can fail to execute for a lot of reasons that can be retrieved by errno, but it only returns -1. This makes difficult for the caller to know what happened and only a generic error message is propagated b

Re: [Qemu-devel] [PATCH v3 1/1] dump.c: allow fd_write_vmcore to return errno on failure

2018-02-12 Thread Eric Blake
On 02/12/2018 08:46 AM, Murilo Opsfelder Araujo wrote: On 02/12/2018 12:25 PM, Daniel Henrique Barboza wrote: From: Yasmin Beatriz fd_write_vmcore can fail to execute for a lot of reasons that can be retrieved by errno, but it only returns -1. This makes difficult for the caller to know what h

Re: [Qemu-devel] [PATCH v3 1/1] dump.c: allow fd_write_vmcore to return errno on failure

2018-02-12 Thread Daniel Henrique Barboza
On 02/12/2018 12:46 PM, Murilo Opsfelder Araujo wrote: On 02/12/2018 12:25 PM, Daniel Henrique Barboza wrote: From: Yasmin Beatriz fd_write_vmcore can fail to execute for a lot of reasons that can be retrieved by errno, but it only returns -1. This makes difficult for the caller to know what

Re: [Qemu-devel] [PATCH v3 1/1] dump.c: allow fd_write_vmcore to return errno on failure

2018-02-12 Thread Murilo Opsfelder Araujo
On 02/12/2018 12:25 PM, Daniel Henrique Barboza wrote: > From: Yasmin Beatriz > > fd_write_vmcore can fail to execute for a lot of reasons that can be > retrieved by errno, but it only returns -1. This makes difficult for > the caller to know what happened and only a generic error message is > pr

Re: [Qemu-devel] [PATCH v3 1/1] dump.c: allow fd_write_vmcore to return errno on failure

2018-02-12 Thread Marc-Andre Lureau
Hi On Mon, Feb 12, 2018 at 3:25 PM, Daniel Henrique Barboza wrote: > From: Yasmin Beatriz > > fd_write_vmcore can fail to execute for a lot of reasons that can be > retrieved by errno, but it only returns -1. This makes difficult for > the caller to know what happened and only a generic error me

[Qemu-devel] [PATCH v3 1/1] dump.c: allow fd_write_vmcore to return errno on failure

2018-02-12 Thread Daniel Henrique Barboza
From: Yasmin Beatriz fd_write_vmcore can fail to execute for a lot of reasons that can be retrieved by errno, but it only returns -1. This makes difficult for the caller to know what happened and only a generic error message is propagated back to the user. This is an example using dump-guest-memo