Re: [Qemu-devel] [PATCH v3 2/9] hw/i386: Adjust nr_dies with configured smp_dies for PCMachine

2019-06-19 Thread Eduardo Habkost
On Wed, Jun 12, 2019 at 04:40:57PM +0800, Like Xu wrote: > To support multiple dies configuration on PCMachine, the best place to > set CPUX86State->nr_dies with requested PCMachineState->smp_dies is in > pc_new_cpu() and pc_cpu_pre_plug(). Refactoring pc_new_cpu() is applied > and redundant

[Qemu-devel] [PATCH v3 2/9] hw/i386: Adjust nr_dies with configured smp_dies for PCMachine

2019-06-12 Thread Like Xu
To support multiple dies configuration on PCMachine, the best place to set CPUX86State->nr_dies with requested PCMachineState->smp_dies is in pc_new_cpu() and pc_cpu_pre_plug(). Refactoring pc_new_cpu() is applied and redundant parameter "const char *typename" would be removed. Suggested-by: