Re: [Qemu-devel] [PATCH v3 for-2.13 1/3] net: Remove the deprecated "vlan" parameter

2018-04-17 Thread Paolo Bonzini
On 17/04/2018 10:08, Thomas Huth wrote: >>> -"-net >>> nic[,vlan=n][,netdev=nd][,macaddr=mac][,model=type][,name=str][,addr=str][,vectors=v]\n" >>> +"-net >>> nic[,macaddr=mac][,model=type][,name=str][,addr=str][,vectors=v]\n" >>> "configure or create an on-board (or

Re: [Qemu-devel] [PATCH v3 for-2.13 1/3] net: Remove the deprecated "vlan" parameter

2018-04-17 Thread Thomas Huth
On 17.04.2018 09:21, Stefan Hajnoczi wrote: > On Mon, Apr 16, 2018 at 08:44:39AM +0200, Thomas Huth wrote: >> @@ -499,10 +497,11 @@ >> # @opts: device type specific properties (legacy) >> # >> # Since: 1.2 >> +# >> +# 'vlan' - removed with 2.12 > > Not sure how to interpret this. How about "re

Re: [Qemu-devel] [PATCH v3 for-2.13 1/3] net: Remove the deprecated "vlan" parameter

2018-04-17 Thread Stefan Hajnoczi
On Mon, Apr 16, 2018 at 08:44:39AM +0200, Thomas Huth wrote: > @@ -499,10 +497,11 @@ > # @opts: device type specific properties (legacy) > # > # Since: 1.2 > +# > +# 'vlan' - removed with 2.12 Not sure how to interpret this. How about "removed in 2.13"? > @@ -2028,10 +2028,9 @@ DEF("nic", HAS

[Qemu-devel] [PATCH v3 for-2.13 1/3] net: Remove the deprecated "vlan" parameter

2018-04-15 Thread Thomas Huth
It's been marked as deprecated since QEMU v2.9.0, so that should have been enough time for everybody to either just drop unnecessary "vlan=0" parameters, to switch to the modern -device + -netdev syntax for connecting guest NICs with host network backends, or to switch to the "hubport" netdev in ca