Re: [Qemu-devel] [PATCH v4 13/35] tcg: Add atomic helpers

2016-10-05 Thread Richard Henderson
On 10/05/2016 04:17 AM, Alex Bennée wrote: /tmp/qemu-test/src/tcg/tcg-op.c:2296:255: error: ‘gen_helper_atomic_xor_fetchl_be’ undeclared here (not in a function) Which makes me wonder in we should be including: #include "exec/helper-proto.h" And if this is generating all the prototypes it

Re: [Qemu-devel] [PATCH v4 13/35] tcg: Add atomic helpers

2016-10-05 Thread Alex Bennée
Emilio G. Cota writes: > On Mon, Oct 03, 2016 at 20:42:43 +0100, Alex Bennée wrote: >> >> Richard Henderson writes: >> >> > Add all of cmpxchg, op_fetch, fetch_op, and xchg. >> > Handle both endian-ness, and sizes up to 8. >> > Handle expanding non-atomically,

Re: [Qemu-devel] [PATCH v4 13/35] tcg: Add atomic helpers

2016-10-04 Thread Emilio G. Cota
On Mon, Oct 03, 2016 at 20:42:43 +0100, Alex Bennée wrote: > > Richard Henderson writes: > > > Add all of cmpxchg, op_fetch, fetch_op, and xchg. > > Handle both endian-ness, and sizes up to 8. > > Handle expanding non-atomically, when emulating in serial. > > > >

Re: [Qemu-devel] [PATCH v4 13/35] tcg: Add atomic helpers

2016-10-03 Thread Alex Bennée
Richard Henderson writes: > Add all of cmpxchg, op_fetch, fetch_op, and xchg. > Handle both endian-ness, and sizes up to 8. > Handle expanding non-atomically, when emulating in serial. > > Signed-off-by: Richard Henderson > --- > diff --git a/tcg/tcg-op.c

[Qemu-devel] [PATCH v4 13/35] tcg: Add atomic helpers

2016-09-16 Thread Richard Henderson
Add all of cmpxchg, op_fetch, fetch_op, and xchg. Handle both endian-ness, and sizes up to 8. Handle expanding non-atomically, when emulating in serial. Signed-off-by: Richard Henderson --- Makefile.objs | 1 - Makefile.target | 1 + atomic_template.h |