Re: [Qemu-devel] [PATCH v5 32/36] spapr/rtas: modify spapr_rtas_register() to remove RTAS handlers

2018-11-29 Thread David Gibson
On Thu, Nov 29, 2018 at 05:40:18PM +0100, Cédric Le Goater wrote: > On 11/29/18 5:12 AM, David Gibson wrote: > > On Fri, Nov 16, 2018 at 11:57:25AM +0100, Cédric Le Goater wrote: > >> Removing RTAS handlers will become necessary when the new pseries > >> machine supporting multiple interrupt mode

Re: [Qemu-devel] [PATCH v5 32/36] spapr/rtas: modify spapr_rtas_register() to remove RTAS handlers

2018-11-29 Thread Cédric Le Goater
On 11/29/18 5:12 AM, David Gibson wrote: > On Fri, Nov 16, 2018 at 11:57:25AM +0100, Cédric Le Goater wrote: >> Removing RTAS handlers will become necessary when the new pseries >> machine supporting multiple interrupt mode is introduced. > > I'd prefer this to be done as a separate

Re: [Qemu-devel] [PATCH v5 32/36] spapr/rtas: modify spapr_rtas_register() to remove RTAS handlers

2018-11-28 Thread David Gibson
On Fri, Nov 16, 2018 at 11:57:25AM +0100, Cédric Le Goater wrote: > Removing RTAS handlers will become necessary when the new pseries > machine supporting multiple interrupt mode is introduced. I'd prefer this to be done as a separate spapr_rtas_unregister() helper, just to improve greppability.

[Qemu-devel] [PATCH v5 32/36] spapr/rtas: modify spapr_rtas_register() to remove RTAS handlers

2018-11-16 Thread Cédric Le Goater
Removing RTAS handlers will become necessary when the new pseries machine supporting multiple interrupt mode is introduced. Signed-off-by: Cédric Le Goater --- hw/ppc/spapr_rtas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index