Re: [Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-24 Thread Riku Voipio
On Sat, Sep 24, 2016 at 10:05:28AM +, Riku Voipio wrote:
> On Thu, Sep 22, 2016 at 07:24:36AM +0100, Leon Alrae wrote:
> > > > Applied to target-mips queue, thanks.
>  
> > > That's a bit unorthodox way but you have my acked-by then..
>  
> > Since these are mips-specific fixes I assumed it doesn't really matter
> > whether it goes via your or my tree (I picked up a few patches like
> > this in the past). Anyway, thanks for ack and next time I'll check with you.
> 
> The main risk here is that the patches conflict with other patches in
> linux-user/ directory, creating potential for merge conflict. Which
> unfortunately might be the case right now, as the main linux-user patchset
> was already merged..

I see it's merged already - sorry for the noise..

Riku



Re: [Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-24 Thread Riku Voipio
On Thu, Sep 22, 2016 at 07:24:36AM +0100, Leon Alrae wrote:
> > > Applied to target-mips queue, thanks.
 
> > That's a bit unorthodox way but you have my acked-by then..
 
> Since these are mips-specific fixes I assumed it doesn't really matter
> whether it goes via your or my tree (I picked up a few patches like
> this in the past). Anyway, thanks for ack and next time I'll check with you.

The main risk here is that the patches conflict with other patches in
linux-user/ directory, creating potential for merge conflict. Which
unfortunately might be the case right now, as the main linux-user patchset
was already merged..

Riku



Re: [Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-21 Thread Leon Alrae
On Wed, Sep 21, 2016 at 07:12:20PM +, Riku Voipio wrote:
> On Wed, Sep 21, 2016 at 02:16:54PM +0100, Leon Alrae wrote:
> > On Mon, Sep 19, 2016 at 01:44:37PM +0200, Aleksandar Markovic wrote:
> > > From: Aleksandar Markovic 
> > > 
> > > v6->v7:
> > > 
> > >   - Rebased to the latest code.
> > >   - Patch 1/1 expanded to act on alpha and sh4.
> > >   - Naming in patch 4/7 synced with kernel naming.
> > >   - Change code style of patch 5/7.
> > >   - Corrected spelling in all patches.
> > > 
> > > v5->v6:
> > > 
> > >   - Corrected two instances of wrong field type in the patch on 
> > > target_flock.
> > >   - Added a patch that corrects handling of EDQUOT error code for Mips.
> > >   - Added a patch that adds missing Mips-related items in strace.list.
> > > 
> > > v4->v5:
> > > 
> > >   - Commit messages improved.
> > > 
> > > v3->v4:
> > > 
> > >   - Added a patch on agrument rearangement.
> > > 
> > > v2->v3:
> > > 
> > >   - Minor fixes in the commit messages.
> > > 
> > > v1->v2:
> > > 
> > >   - Improved a comment in the patch about target_semid64_ds (now 4/4).
> > >   - Added a patch that fixes TARGET_SIOCATMARK for Mips.
> > >   - Changed order of patches to be more structured.
> > > 
> > > This series fixes several wrong definitions of preprocessor constants and
> > > structures in Qemu user mode, as well as two other Mips-related problems.
> > > 
> > > Aleksandar Markovic (7):
> > >   linux-user: Fix TARGET_SIOCATMARK definition for Mips
> > >   linux-user: Fix TARGET_F_GETOWN definition for Mips
> > >   linux-user: Fix structure target_flock definition for Mips
> > >   linux-user: Fix structure target_semid64_ds definition for Mips
> > >   linux-user: Fix certain argument alignment cases for Mips64
> > >   linux-user: Add missing TARGET_EDQUOT error code for Mips
> > >   linux-user: Add missing Mips syscalls items in strace.list
> > > 
> > >  linux-user/mips/target_structs.h   |  16 ++
> > >  linux-user/mips/target_syscall.h   |   2 +
> > >  linux-user/mips64/target_syscall.h |   2 +
> > >  linux-user/strace.list | 114 
> > > +
> > >  linux-user/syscall.c   |   3 +-
> > >  linux-user/syscall_defs.h  |  12 +++-
> > >  6 files changed, 147 insertions(+), 2 deletions(-)
> > 
> > Applied to target-mips queue, thanks.
> 
> That's a bit unorthodox way but you have my acked-by then..

Since these are mips-specific fixes I assumed it doesn't really matter
whether it goes via your or my tree (I picked up a few patches like
this in the past). Anyway, thanks for ack and next time I'll check with you.

Leon



Re: [Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-21 Thread Riku Voipio
On Wed, Sep 21, 2016 at 02:16:54PM +0100, Leon Alrae wrote:
> On Mon, Sep 19, 2016 at 01:44:37PM +0200, Aleksandar Markovic wrote:
> > From: Aleksandar Markovic 
> > 
> > v6->v7:
> > 
> >   - Rebased to the latest code.
> >   - Patch 1/1 expanded to act on alpha and sh4.
> >   - Naming in patch 4/7 synced with kernel naming.
> >   - Change code style of patch 5/7.
> >   - Corrected spelling in all patches.
> > 
> > v5->v6:
> > 
> >   - Corrected two instances of wrong field type in the patch on 
> > target_flock.
> >   - Added a patch that corrects handling of EDQUOT error code for Mips.
> >   - Added a patch that adds missing Mips-related items in strace.list.
> > 
> > v4->v5:
> > 
> >   - Commit messages improved.
> > 
> > v3->v4:
> > 
> >   - Added a patch on agrument rearangement.
> > 
> > v2->v3:
> > 
> >   - Minor fixes in the commit messages.
> > 
> > v1->v2:
> > 
> >   - Improved a comment in the patch about target_semid64_ds (now 4/4).
> >   - Added a patch that fixes TARGET_SIOCATMARK for Mips.
> >   - Changed order of patches to be more structured.
> > 
> > This series fixes several wrong definitions of preprocessor constants and
> > structures in Qemu user mode, as well as two other Mips-related problems.
> > 
> > Aleksandar Markovic (7):
> >   linux-user: Fix TARGET_SIOCATMARK definition for Mips
> >   linux-user: Fix TARGET_F_GETOWN definition for Mips
> >   linux-user: Fix structure target_flock definition for Mips
> >   linux-user: Fix structure target_semid64_ds definition for Mips
> >   linux-user: Fix certain argument alignment cases for Mips64
> >   linux-user: Add missing TARGET_EDQUOT error code for Mips
> >   linux-user: Add missing Mips syscalls items in strace.list
> > 
> >  linux-user/mips/target_structs.h   |  16 ++
> >  linux-user/mips/target_syscall.h   |   2 +
> >  linux-user/mips64/target_syscall.h |   2 +
> >  linux-user/strace.list | 114 
> > +
> >  linux-user/syscall.c   |   3 +-
> >  linux-user/syscall_defs.h  |  12 +++-
> >  6 files changed, 147 insertions(+), 2 deletions(-)
> 
> Applied to target-mips queue, thanks.

That's a bit unorthodox way but you have my acked-by then..

Riku



Re: [Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-21 Thread Leon Alrae
On Mon, Sep 19, 2016 at 01:44:37PM +0200, Aleksandar Markovic wrote:
> From: Aleksandar Markovic 
> 
> v6->v7:
> 
>   - Rebased to the latest code.
>   - Patch 1/1 expanded to act on alpha and sh4.
>   - Naming in patch 4/7 synced with kernel naming.
>   - Change code style of patch 5/7.
>   - Corrected spelling in all patches.
> 
> v5->v6:
> 
>   - Corrected two instances of wrong field type in the patch on target_flock.
>   - Added a patch that corrects handling of EDQUOT error code for Mips.
>   - Added a patch that adds missing Mips-related items in strace.list.
> 
> v4->v5:
> 
>   - Commit messages improved.
> 
> v3->v4:
> 
>   - Added a patch on agrument rearangement.
> 
> v2->v3:
> 
>   - Minor fixes in the commit messages.
> 
> v1->v2:
> 
>   - Improved a comment in the patch about target_semid64_ds (now 4/4).
>   - Added a patch that fixes TARGET_SIOCATMARK for Mips.
>   - Changed order of patches to be more structured.
> 
> This series fixes several wrong definitions of preprocessor constants and
> structures in Qemu user mode, as well as two other Mips-related problems.
> 
> Aleksandar Markovic (7):
>   linux-user: Fix TARGET_SIOCATMARK definition for Mips
>   linux-user: Fix TARGET_F_GETOWN definition for Mips
>   linux-user: Fix structure target_flock definition for Mips
>   linux-user: Fix structure target_semid64_ds definition for Mips
>   linux-user: Fix certain argument alignment cases for Mips64
>   linux-user: Add missing TARGET_EDQUOT error code for Mips
>   linux-user: Add missing Mips syscalls items in strace.list
> 
>  linux-user/mips/target_structs.h   |  16 ++
>  linux-user/mips/target_syscall.h   |   2 +
>  linux-user/mips64/target_syscall.h |   2 +
>  linux-user/strace.list | 114 
> +
>  linux-user/syscall.c   |   3 +-
>  linux-user/syscall_defs.h  |  12 +++-
>  6 files changed, 147 insertions(+), 2 deletions(-)

Applied to target-mips queue, thanks.

Leon



[Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-19 Thread Aleksandar Markovic
From: Aleksandar Markovic 

v6->v7:

  - Rebased to the latest code.
  - Patch 1/1 expanded to act on alpha and sh4.
  - Naming in patch 4/7 synced with kernel naming.
  - Change code style of patch 5/7.
  - Corrected spelling in all patches.

v5->v6:

  - Corrected two instances of wrong field type in the patch on target_flock.
  - Added a patch that corrects handling of EDQUOT error code for Mips.
  - Added a patch that adds missing Mips-related items in strace.list.

v4->v5:

  - Commit messages improved.

v3->v4:

  - Added a patch on agrument rearangement.

v2->v3:

  - Minor fixes in the commit messages.

v1->v2:

  - Improved a comment in the patch about target_semid64_ds (now 4/4).
  - Added a patch that fixes TARGET_SIOCATMARK for Mips.
  - Changed order of patches to be more structured.

This series fixes several wrong definitions of preprocessor constants and
structures in Qemu user mode, as well as two other Mips-related problems.

Aleksandar Markovic (7):
  linux-user: Fix TARGET_SIOCATMARK definition for Mips
  linux-user: Fix TARGET_F_GETOWN definition for Mips
  linux-user: Fix structure target_flock definition for Mips
  linux-user: Fix structure target_semid64_ds definition for Mips
  linux-user: Fix certain argument alignment cases for Mips64
  linux-user: Add missing TARGET_EDQUOT error code for Mips
  linux-user: Add missing Mips syscalls items in strace.list

 linux-user/mips/target_structs.h   |  16 ++
 linux-user/mips/target_syscall.h   |   2 +
 linux-user/mips64/target_syscall.h |   2 +
 linux-user/strace.list | 114 +
 linux-user/syscall.c   |   3 +-
 linux-user/syscall_defs.h  |  12 +++-
 6 files changed, 147 insertions(+), 2 deletions(-)

-- 
2.9.3