Re: [Qemu-devel] [PATCH v7 00/10] linux-user: Fix assorted Qemu user mode issues

2016-09-24 Thread Riku Voipio 
On Thu, Sep 22, 2016 at 06:56:49PM +0200, Aleksandar Markovic wrote:
> This series fixes certain Qemu user mode issues. The fixes mainly originate
> from observation of LTP tests failures for execution in Qemu user mode on
> various platforms. The series also contains a cleanup patch.

Thanks, all except the sysfs patch have been applied to
linux-user-for-upstream que.

Riku

Re: [Qemu-devel] [PATCH v7 00/10] linux-user: Fix assorted Qemu user mode issues

2016-09-23 Thread Laurent Vivier 


Le 23/09/2016 à 10:43, Aleksandar Markovic a écrit :
> > - changed PATH_MAX to 128 in sysfs() patch (last remaining item
> > that was supposed to be in the previous version)/
> 
> At first glance of the patch, you didn't change the good PATH_MAX...
> 
> Laurent/
> 
> It slipped through the cracks. Sorry. :( My bad. But all other changes
> are in. Rebase is also good, this series sits *after* 26-patch
> linux-user change. Speaking about PATH_MAX, I intended to replace it
> with hardcoded 128. However, another possibility is replacing it with
> NAME_MAX (255). Or to leave PATH_MAX (4096)? Or something else
> altogether? What do you think? Thanks, Aleksandar

I've looked at the kernel code and there is no defined value for this
length (this is a pointer to a string), but it seems the length of the
longest string is 14 [1]. So 4096 seems really overkill.

Laurent

[1] grep -rh -A3 "struct file_system_type " . |grep "\.name" |sed -n
's/[^"]*"\([^"]*\)".*/\1/p'|while read name; do echo $name|wc -c;
done|sort -n|tail -1

Re: [Qemu-devel] [PATCH v7 00/10] linux-user: Fix assorted Qemu user mode issues

2016-09-23 Thread Aleksandar Markovic 
> - changed PATH_MAX to 128 in sysfs() patch (last remaining item
> that was supposed to be in the previous version)

At first glance of the patch, you didn't change the good PATH_MAX...

Laurent

It slipped through the cracks. Sorry. :( My bad. But all other changes are in. 
Rebase is also good, this series sits *after* 26-patch linux-user change. 
Speaking about PATH_MAX, I intended to replace it with hardcoded 128. However, 
another possibility is replacing it with NAME_MAX (255). Or to leave PATH_MAX 
(4096)? Or something else altogether? What do you think? Thanks, Aleksandar

Re: [Qemu-devel] [PATCH v7 00/10] linux-user: Fix assorted Qemu user mode issues

2016-09-22 Thread Laurent Vivier 


Le 22/09/2016 à 18:56, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic 
> 
> v6->v7:
> 
> - rebased to the latest code (there was a large linux-user change since
>   v6, consisting of 26 patches)
> - slightly changed order of patches
> - changed PATH_MAX to 128 in sysfs() patch (last remaining item
>   that was supposed to be in the previous version) 

At first glance of the patch, you didn't change the good PATH_MAX...

Laurent

[Qemu-devel] [PATCH v7 00/10] linux-user: Fix assorted Qemu user mode issues

2016-09-22 Thread Aleksandar Markovic 
From: Aleksandar Markovic 

v6->v7:

- rebased to the latest code (there was a large linux-user change since
  v6, consisting of 26 patches)
- slightly changed order of patches
- changed PATH_MAX to 128 in sysfs() patch (last remaining item
  that was supposed to be in the previous version) 

v5->v6:

- rebased to the latest code
- reworked all patches according to review feedback
- added two new patches on syncfs() and mq_open()
- some improvements in commit messages

v4->v5:

- removed three cleanup patches

v3->v4:

- rebased to the latest code
- added patch on clock_adjtime() support
- minor commit messages improvements

v2->v3:

- rebased to the latest code
- merged patches on adjtimex(), sysfs(), and ustat() from another series
- added patch on socketcall() support
- cleanup patches reorganized

v1->v2:

- improved usage of "#ifdefs" in patch on syslog()
- removed EIDRM-related code from patch on msgrcv(), since this error
  code is already handled well
- added three cleanup patches

(v1 for some reason did not appear on qemu-devel, but mails are sent)

This series fixes certain Qemu user mode issues. The fixes mainly originate
from observation of LTP tests failures for execution in Qemu user mode on
various platforms. The series also contains a cleanup patch.

Aleksandar Markovic (10):
  linux-user: Add support for adjtimex() syscall
  linux-user: Add support for clock_adjtime() syscall
  linux-user: Add support for syncfs() syscall
  linux-user: Add support for sysfs() syscall
  linux-user: Add support for ustat() syscall
  linux-user: Fix mq_open() syscall support
  linux-user: Fix msgrcv() and msgsnd() syscalls support
  linux-user: Fix socketcall() syscall support
  linux-user: Fix syslog() syscall support
  linux-user: Remove a duplicate item from strace.list

 linux-user/strace.c   | 260 ++---
 linux-user/strace.list|  13 +-
 linux-user/syscall.c  | 358 --
 linux-user/syscall_defs.h | 101 ++---
 4 files changed, 612 insertions(+), 120 deletions(-)

-- 
2.9.3