Re: [Qemu-devel] [PATCH v8 02/21] nvme: Drop pointless .bdrv_co_get_block_status()

2018-02-14 Thread Philippe Mathieu-Daudé
On 02/13/2018 05:26 PM, Eric Blake wrote: > Commit bdd6a90 has a bug: drivers should never directly set > BDRV_BLOCK_ALLOCATED, but only io.c should do that (as needed). Doesn't "pointless" in subject hide this is a bugfix? > Instead, drivers should report BDRV_BLOCK_DATA if it knows that > data

[Qemu-devel] [PATCH v8 02/21] nvme: Drop pointless .bdrv_co_get_block_status()

2018-02-13 Thread Eric Blake
Commit bdd6a90 has a bug: drivers should never directly set BDRV_BLOCK_ALLOCATED, but only io.c should do that (as needed). Instead, drivers should report BDRV_BLOCK_DATA if it knows that data comes from this BDS. But let's look at the bigger picture: semantically, the nvme driver is similar to