Re: [Qemu-devel] [PATCHv2 03/12] cuda: don't call cuda_update() when writing to ACR register

2018-02-10 Thread David Gibson
On Fri, Feb 09, 2018 at 06:51:33PM +, Mark Cave-Ayland wrote:
> The wire protocol for reading data to/from the VIA is triggered by changing
> inputs on port B rather than changing the timer configuration via the ACR.
> 
> Signed-off-by: Mark Cave-Ayland 

Applied, thanks.

> ---
>  hw/misc/macio/cuda.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c
> index eaa8924f49..1d0f7e8289 100644
> --- a/hw/misc/macio/cuda.c
> +++ b/hw/misc/macio/cuda.c
> @@ -406,7 +406,6 @@ static void cuda_write(void *opaque, hwaddr addr, 
> uint64_t val, unsigned size)
>  case CUDA_REG_ACR:
>  s->acr = val;
>  cuda_timer_update(s, >timers[0], 
> qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL));
> -cuda_update(s);
>  break;
>  case CUDA_REG_PCR:
>  s->pcr = val;

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature


[Qemu-devel] [PATCHv2 03/12] cuda: don't call cuda_update() when writing to ACR register

2018-02-09 Thread Mark Cave-Ayland
The wire protocol for reading data to/from the VIA is triggered by changing
inputs on port B rather than changing the timer configuration via the ACR.

Signed-off-by: Mark Cave-Ayland 
---
 hw/misc/macio/cuda.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c
index eaa8924f49..1d0f7e8289 100644
--- a/hw/misc/macio/cuda.c
+++ b/hw/misc/macio/cuda.c
@@ -406,7 +406,6 @@ static void cuda_write(void *opaque, hwaddr addr, uint64_t 
val, unsigned size)
 case CUDA_REG_ACR:
 s->acr = val;
 cuda_timer_update(s, >timers[0], 
qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL));
-cuda_update(s);
 break;
 case CUDA_REG_PCR:
 s->pcr = val;
-- 
2.11.0