Re: [Qemu-devel] [PULL 0/6] Net patches

[Peter Maydell]

On 10 April 2018 at 04:39, Jason Wang  wrote:
> The following changes since commit 915d34c5f99b0ab91517c69f54272bfdb6ca2b32:
>
>   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into 
> staging (2018-04-09 17:29:10 +0100)
>
> are available in the git repository at:
>
>   https://github.com/jasowang/qemu.git tags/net-pull-request
>
> for you to fetch changes up to 5f523530915e57a14ffb8c00e22252bfa557441c:
>
>   e1000: Old machine types, turn new subsection off (2018-04-10 11:30:04 
> +0800)
>
> 
>
> A series from David that switches to use subsection instead of version
> bumping for e1000 to keep migration compatibility for old
> versions. This will ease the downstream maintaining.
>
> Please merge.
>
> Thanks
>
> 
> Dr. David Alan Gilbert (6):
>   e1000: Convert v3 fields to subsection
>   e1000: Dupe offload data on reading old stream
>   e1000: wire new subsection to property
>   e1000: Migrate props via a temporary structure
>   e1000: Choose which set of props to migrate
>   e1000: Old machine types, turn new subsection off
>
>  hw/net/e1000.c  | 103 
> 
>  include/hw/compat.h |   4 ++
>  2 files changed, 84 insertions(+), 23 deletions(-)

Applied, thanks.

-- PMM

[Qemu-devel] [PULL 0/6] Net patches

[Jason Wang]

The following changes since commit 915d34c5f99b0ab91517c69f54272bfdb6ca2b32:

  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging 
(2018-04-09 17:29:10 +0100)

are available in the git repository at:

  https://github.com/jasowang/qemu.git tags/net-pull-request

for you to fetch changes up to 5f523530915e57a14ffb8c00e22252bfa557441c:

  e1000: Old machine types, turn new subsection off (2018-04-10 11:30:04 +0800)



A series from David that switches to use subsection instead of version
bumping for e1000 to keep migration compatibility for old
versions. This will ease the downstream maintaining.

Please merge.

Thanks


Dr. David Alan Gilbert (6):
  e1000: Convert v3 fields to subsection
  e1000: Dupe offload data on reading old stream
  e1000: wire new subsection to property
  e1000: Migrate props via a temporary structure
  e1000: Choose which set of props to migrate
  e1000: Old machine types, turn new subsection off

 hw/net/e1000.c  | 103 
 include/hw/compat.h |   4 ++
 2 files changed, 84 insertions(+), 23 deletions(-)

Re: [Qemu-devel] [PULL 0/6] Net patches

[Peter Maydell]

On 29 January 2018 at 08:16, Jason Wang  wrote:
> The following changes since commit e607bbee553cfe73072870cef458cfa4e78133e2:
>
>   Merge remote-tracking branch 
> 'remotes/edgar/tags/edgar/xilinx-next-2018-01-26.for-upstream' into staging 
> (2018-01-26 14:24:25 +)
>
> are available in the git repository at:
>
>   https://github.com/jasowang/qemu.git tags/net-pull-request
>
> for you to fetch changes up to bf4835a4d5338bb7424827715df22570a8adc67c:
>
>   MAINTAINERS: update Dmitry Fleytman email (2018-01-29 16:05:38 +0800)
>
> 
>
> 
> Mao Zhongyi (2):
>   colo: modified the payload compare function
>   colo: compare the packet based on the tcp sequence number
>
> Philippe Mathieu-Daudé (1):
>   MAINTAINERS: update Dmitry Fleytman email
>
> Thomas Huth (3):
>   net: Allow hubports to connect to other netdevs
>   net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove'
>   qemu-doc: Get rid of "vlan=X" example in the documentation
>

Applied, thanks.

-- PMM

Re: [Qemu-devel] [PULL 0/6] Net patches

[Jason Wang]

On 2018年01月29日 18:58, Thomas Huth wrote:

On 29.01.2018 11:02, Jason Wang wrote:


On 2018年01月29日 16:25, no-re...@patchew.org wrote:

Hi,

This series seems to have some coding style problems. See output below
for
more information:

Type: series
Message-id: 1517213825-24085-1-git-send-email-jasow...@redhat.com
Subject: [Qemu-devel] [PULL 0/6] Net patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
  echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
  if ! git show $c --format=email | ./scripts/checkpatch.pl
--mailback -; then
  failed=1
  echo
  fi
  n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
  From https://github.com/patchew-project/qemu
   * [new tag]
patchew/1517213825-24085-1-git-send-email-jasow...@redhat.com ->
patchew/1517213825-24085-1-git-send-email-jasow...@redhat.com
Switched to a new branch 'test'
f599bb830a MAINTAINERS: update Dmitry Fleytman email
d7e337961c qemu-doc: Get rid of "vlan=X" example in the documentation
b7bc06c0f4 net: Allow netdevs to be used with 'hostfwd_add' and
'hostfwd_remove'
85b4cac4ac net: Allow hubports to connect to other netdevs
b4a35413c4 colo: compare the packet based on the tcp sequence number
f6781da302 colo: modified the payload compare function

=== OUTPUT BEGIN ===
Checking PATCH 1/6: colo: modified the payload compare function...
Checking PATCH 2/6: colo: compare the packet based on the tcp sequence
number...
Checking PATCH 3/6: net: Allow hubports to connect to other netdevs...
Checking PATCH 4/6: net: Allow netdevs to be used with 'hostfwd_add'
and 'hostfwd_remove'...
ERROR: consider using qemu_strtol in preference to strtol
#72: FILE: net/slirp.c:414:
+    nc = net_hub_find_client_by_name(strtol(hub_id, NULL, 0),
name);

total: 1 errors, 0 warnings, 73 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/6: qemu-doc: Get rid of "vlan=X" example in the
documentation...
Checking PATCH 6/6: MAINTAINERS: update Dmitry Fleytman email...
=== OUTPUT END ===

Test command exited with code: 1

Thomas, want to send a v2 for this patch?

No, that strtol was already there in the code before my patch, I just
changed the indentation. If we decide that we want to replace it, this
should be done by a separate patch instead. Question is: Do we really
want to replace it here? (the error message is saying "consider ..." -
so maybe that should also rather be a warning instead of an error message?)

  Thomas



I see, then I'm fine to keep it as is. Any changes could be done on top.

Thanks

Re: [Qemu-devel] [PULL 0/6] Net patches

[Thomas Huth]

On 29.01.2018 11:02, Jason Wang wrote:
> 
> 
> On 2018年01月29日 16:25, no-re...@patchew.org wrote:
>> Hi,
>>
>> This series seems to have some coding style problems. See output below
>> for
>> more information:
>>
>> Type: series
>> Message-id: 1517213825-24085-1-git-send-email-jasow...@redhat.com
>> Subject: [Qemu-devel] [PULL 0/6] Net patches
>>
>> === TEST SCRIPT BEGIN ===
>> #!/bin/bash
>>
>> BASE=base
>> n=1
>> total=$(git log --oneline $BASE.. | wc -l)
>> failed=0
>>
>> git config --local diff.renamelimit 0
>> git config --local diff.renames True
>>
>> commits="$(git log --format=%H --reverse $BASE..)"
>> for c in $commits; do
>>  echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
>>  if ! git show $c --format=email | ./scripts/checkpatch.pl
>> --mailback -; then
>>  failed=1
>>  echo
>>  fi
>>  n=$((n+1))
>> done
>>
>> exit $failed
>> === TEST SCRIPT END ===
>>
>> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>>  From https://github.com/patchew-project/qemu
>>   * [new tag]  
>> patchew/1517213825-24085-1-git-send-email-jasow...@redhat.com ->
>> patchew/1517213825-24085-1-git-send-email-jasow...@redhat.com
>> Switched to a new branch 'test'
>> f599bb830a MAINTAINERS: update Dmitry Fleytman email
>> d7e337961c qemu-doc: Get rid of "vlan=X" example in the documentation
>> b7bc06c0f4 net: Allow netdevs to be used with 'hostfwd_add' and
>> 'hostfwd_remove'
>> 85b4cac4ac net: Allow hubports to connect to other netdevs
>> b4a35413c4 colo: compare the packet based on the tcp sequence number
>> f6781da302 colo: modified the payload compare function
>>
>> === OUTPUT BEGIN ===
>> Checking PATCH 1/6: colo: modified the payload compare function...
>> Checking PATCH 2/6: colo: compare the packet based on the tcp sequence
>> number...
>> Checking PATCH 3/6: net: Allow hubports to connect to other netdevs...
>> Checking PATCH 4/6: net: Allow netdevs to be used with 'hostfwd_add'
>> and 'hostfwd_remove'...
>> ERROR: consider using qemu_strtol in preference to strtol
>> #72: FILE: net/slirp.c:414:
>> +    nc = net_hub_find_client_by_name(strtol(hub_id, NULL, 0),
>> name);
>>
>> total: 1 errors, 0 warnings, 73 lines checked
>>
>> Your patch has style problems, please review.  If any of these errors
>> are false positives report them to the maintainer, see
>> CHECKPATCH in MAINTAINERS.
>>
>> Checking PATCH 5/6: qemu-doc: Get rid of "vlan=X" example in the
>> documentation...
>> Checking PATCH 6/6: MAINTAINERS: update Dmitry Fleytman email...
>> === OUTPUT END ===
>>
>> Test command exited with code: 1
> 
> Thomas, want to send a v2 for this patch?

No, that strtol was already there in the code before my patch, I just
changed the indentation. If we decide that we want to replace it, this
should be done by a separate patch instead. Question is: Do we really
want to replace it here? (the error message is saying "consider ..." -
so maybe that should also rather be a warning instead of an error message?)

 Thomas

Re: [Qemu-devel] [PULL 0/6] Net patches

[Jason Wang]

On 2018年01月29日 16:25, no-re...@patchew.org wrote:

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1517213825-24085-1-git-send-email-jasow...@redhat.com
Subject: [Qemu-devel] [PULL 0/6] Net patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
 echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
 if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; 
then
 failed=1
 echo
 fi
 n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
 From https://github.com/patchew-project/qemu
  * [new tag]   
patchew/1517213825-24085-1-git-send-email-jasow...@redhat.com -> 
patchew/1517213825-24085-1-git-send-email-jasow...@redhat.com
Switched to a new branch 'test'
f599bb830a MAINTAINERS: update Dmitry Fleytman email
d7e337961c qemu-doc: Get rid of "vlan=X" example in the documentation
b7bc06c0f4 net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove'
85b4cac4ac net: Allow hubports to connect to other netdevs
b4a35413c4 colo: compare the packet based on the tcp sequence number
f6781da302 colo: modified the payload compare function

=== OUTPUT BEGIN ===
Checking PATCH 1/6: colo: modified the payload compare function...
Checking PATCH 2/6: colo: compare the packet based on the tcp sequence number...
Checking PATCH 3/6: net: Allow hubports to connect to other netdevs...
Checking PATCH 4/6: net: Allow netdevs to be used with 'hostfwd_add' and 
'hostfwd_remove'...
ERROR: consider using qemu_strtol in preference to strtol
#72: FILE: net/slirp.c:414:
+nc = net_hub_find_client_by_name(strtol(hub_id, NULL, 0), name);

total: 1 errors, 0 warnings, 73 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/6: qemu-doc: Get rid of "vlan=X" example in the 
documentation...
Checking PATCH 6/6: MAINTAINERS: update Dmitry Fleytman email...
=== OUTPUT END ===

Test command exited with code: 1


Thomas, want to send a v2 for this patch?

Thanks

Re: [Qemu-devel] [PULL 0/6] Net patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1517213825-24085-1-git-send-email-jasow...@redhat.com
Subject: [Qemu-devel] [PULL 0/6] Net patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]   
patchew/1517213825-24085-1-git-send-email-jasow...@redhat.com -> 
patchew/1517213825-24085-1-git-send-email-jasow...@redhat.com
Switched to a new branch 'test'
f599bb830a MAINTAINERS: update Dmitry Fleytman email
d7e337961c qemu-doc: Get rid of "vlan=X" example in the documentation
b7bc06c0f4 net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove'
85b4cac4ac net: Allow hubports to connect to other netdevs
b4a35413c4 colo: compare the packet based on the tcp sequence number
f6781da302 colo: modified the payload compare function

=== OUTPUT BEGIN ===
Checking PATCH 1/6: colo: modified the payload compare function...
Checking PATCH 2/6: colo: compare the packet based on the tcp sequence number...
Checking PATCH 3/6: net: Allow hubports to connect to other netdevs...
Checking PATCH 4/6: net: Allow netdevs to be used with 'hostfwd_add' and 
'hostfwd_remove'...
ERROR: consider using qemu_strtol in preference to strtol
#72: FILE: net/slirp.c:414:
+nc = net_hub_find_client_by_name(strtol(hub_id, NULL, 0), name);

total: 1 errors, 0 warnings, 73 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/6: qemu-doc: Get rid of "vlan=X" example in the 
documentation...
Checking PATCH 6/6: MAINTAINERS: update Dmitry Fleytman email...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org

[Qemu-devel] [PULL 0/6] Net patches

[Jason Wang]

The following changes since commit e607bbee553cfe73072870cef458cfa4e78133e2:

  Merge remote-tracking branch 
'remotes/edgar/tags/edgar/xilinx-next-2018-01-26.for-upstream' into staging 
(2018-01-26 14:24:25 +)

are available in the git repository at:

  https://github.com/jasowang/qemu.git tags/net-pull-request

for you to fetch changes up to bf4835a4d5338bb7424827715df22570a8adc67c:

  MAINTAINERS: update Dmitry Fleytman email (2018-01-29 16:05:38 +0800)




Mao Zhongyi (2):
  colo: modified the payload compare function
  colo: compare the packet based on the tcp sequence number

Philippe Mathieu-Daudé (1):
  MAINTAINERS: update Dmitry Fleytman email

Thomas Huth (3):
  net: Allow hubports to connect to other netdevs
  net: Allow netdevs to be used with 'hostfwd_add' and 'hostfwd_remove'
  qemu-doc: Get rid of "vlan=X" example in the documentation

 MAINTAINERS|   8 +-
 hmp-commands.hx|   4 +-
 net/colo-compare.c | 411 +
 net/colo.c |   9 ++
 net/colo.h |  15 ++
 net/hub.c  |  27 +++-
 net/hub.h  |   3 +-
 net/net.c  |   2 +-
 net/slirp.c|  33 +++--
 net/trace-events   |   2 +-
 qapi/net.json  |   4 +-
 qemu-options.hx|  12 +-
 12 files changed, 347 insertions(+), 183 deletions(-)

Re: [Qemu-devel] [PULL 0/6] Net patches

[Peter Maydell]

On 20 November 2017 at 03:31, Jason Wang  wrote:
> The following changes since commit 2e02083438962d26ef9dcc7100f3b378104183db:
>
>   Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging 
> (2017-11-17 19:08:07 +)
>
> are available in the git repository at:
>
>   https://github.com/jasowang/qemu.git tags/net-pull-request
>
> for you to fetch changes up to c527e0afcd7d719abc3a5ca5e4c8ac2fe48b999f:
>
>   hw/net/vmxnet3: Fix code to work on big endian hosts, too (2017-11-20 
> 11:08:00 +0800)
>
> 
>
> 


Applied, thanks.

-- PMM

Re: [Qemu-devel] [PULL 0/6] Net patches

[Thomas Huth]

On 20.11.2017 04:44, no-re...@patchew.org wrote:
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [Qemu-devel] [PULL 0/6] Net patches
> Type: series
> Message-id: 1511148687-24909-1-git-send-email-jasow...@redhat.com
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> 
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
> 
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> 
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
> echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; 
> then
> failed=1
> echo
> fi
> n=$((n+1))
> done
> 
> exit $failed
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>  t [tag update]
> patchew/1510926167-23326-1-git-send-email-mark.cave-ayl...@ilande.co.uk -> 
> patchew/1510926167-23326-1-git-send-email-mark.cave-ayl...@ilande.co.uk
>  * [new tag]   
> patchew/1511148687-24909-1-git-send-email-jasow...@redhat.com -> 
> patchew/1511148687-24909-1-git-send-email-jasow...@redhat.com
> Switched to a new branch 'test'
> 6d998dcb3e hw/net/vmxnet3: Fix code to work on big endian hosts, too
> e3b7d3045b net: Transmit zero UDP checksum as 0x
> 528693e2ba MAINTAINERS: Add missing entry for eepro100 emulation
> 434d3f0987 hw/net/eepro100: Fix endianness problem on big endian hosts
> c2e0b52dd7 Revert "Add new PCI ID for i82559a"
> 3e70742c2d colo-compare: fix the dangerous assignment
> 
> === OUTPUT BEGIN ===
> Checking PATCH 1/6: colo-compare: fix the dangerous assignment...
> Checking PATCH 2/6: Revert "Add new PCI ID for i82559a"...
> Checking PATCH 3/6: hw/net/eepro100: Fix endianness problem on big endian 
> hosts...
> Checking PATCH 4/6: MAINTAINERS: Add missing entry for eepro100 emulation...
> Checking PATCH 5/6: net: Transmit zero UDP checksum as 0x...
> Checking PATCH 6/6: hw/net/vmxnet3: Fix code to work on big endian hosts, 
> too...
> ERROR: spaces required around that ':' (ctx:VxV)
> #237: FILE: hw/net/vmxnet3.h:232:
> +u32 msscof:14;  /* MSS, checksum offset, flags */
>^
> 
> ERROR: spaces required around that ':' (ctx:VxV)
> #238: FILE: hw/net/vmxnet3.h:233:
> +u32 ext1:1;
>  ^

Just for the records (again): These errors seem to be false positives
from checkpatch. I originally tried to add spaces to all changed
bitfields, but then checkpatch suddenly complains that spaces are not
allowed there...

 Thomas

Re: [Qemu-devel] [PULL 0/6] Net patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 0/6] Net patches
Type: series
Message-id: 1511148687-24909-1-git-send-email-jasow...@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]
patchew/1510926167-23326-1-git-send-email-mark.cave-ayl...@ilande.co.uk -> 
patchew/1510926167-23326-1-git-send-email-mark.cave-ayl...@ilande.co.uk
 * [new tag]   
patchew/1511148687-24909-1-git-send-email-jasow...@redhat.com -> 
patchew/1511148687-24909-1-git-send-email-jasow...@redhat.com
Switched to a new branch 'test'
6d998dcb3e hw/net/vmxnet3: Fix code to work on big endian hosts, too
e3b7d3045b net: Transmit zero UDP checksum as 0x
528693e2ba MAINTAINERS: Add missing entry for eepro100 emulation
434d3f0987 hw/net/eepro100: Fix endianness problem on big endian hosts
c2e0b52dd7 Revert "Add new PCI ID for i82559a"
3e70742c2d colo-compare: fix the dangerous assignment

=== OUTPUT BEGIN ===
Checking PATCH 1/6: colo-compare: fix the dangerous assignment...
Checking PATCH 2/6: Revert "Add new PCI ID for i82559a"...
Checking PATCH 3/6: hw/net/eepro100: Fix endianness problem on big endian 
hosts...
Checking PATCH 4/6: MAINTAINERS: Add missing entry for eepro100 emulation...
Checking PATCH 5/6: net: Transmit zero UDP checksum as 0x...
Checking PATCH 6/6: hw/net/vmxnet3: Fix code to work on big endian hosts, too...
ERROR: spaces required around that ':' (ctx:VxV)
#237: FILE: hw/net/vmxnet3.h:232:
+u32 msscof:14;  /* MSS, checksum offset, flags */
   ^

ERROR: spaces required around that ':' (ctx:VxV)
#238: FILE: hw/net/vmxnet3.h:233:
+u32 ext1:1;
 ^

ERROR: spaces required around that ':' (ctx:VxV)
#239: FILE: hw/net/vmxnet3.h:234:
+u32 dtype:1;/* descriptor type */
  ^

ERROR: spaces required around that ':' (ctx:VxV)
#240: FILE: hw/net/vmxnet3.h:235:
+u32 rsvd:1;
 ^

ERROR: spaces required around that ':' (ctx:VxV)
#241: FILE: hw/net/vmxnet3.h:236:
+u32 gen:1;  /* generation bit */
^

ERROR: spaces required around that ':' (ctx:VxV)
#242: FILE: hw/net/vmxnet3.h:237:
+u32 len:14;
^

ERROR: spaces required around that ':' (ctx:VxV)
#250: FILE: hw/net/vmxnet3.h:239:
+u32 len:14;
^

ERROR: spaces required around that ':' (ctx:VxV)
#251: FILE: hw/net/vmxnet3.h:240:
+u32 gen:1;  /* generation bit */
^

ERROR: spaces required around that ':' (ctx:VxV)
#252: FILE: hw/net/vmxnet3.h:241:
+u32 rsvd:1;
 ^

ERROR: spaces required around that ':' (ctx:VxV)
#253: FILE: hw/net/vmxnet3.h:242:
+u32 dtype:1;/* descriptor type */
  ^

ERROR: spaces required around that ':' (ctx:VxV)
#254: FILE: hw/net/vmxnet3.h:243:
+u32 ext1:1;
 ^

ERROR: spaces required around that ':' (ctx:VxV)
#255: FILE: hw/net/vmxnet3.h:244:
+u32 msscof:14;  /* MSS, checksum offset, flags */
   ^

ERROR: trailing whitespace
#261: FILE: hw/net/vmxnet3.h:249:
+$

WARNING: architecture specific defines should be avoided
#310: FILE: hw/net/vmxnet3.h:306:
+#ifdef __BIG_ENDIAN_BITFIELD

WARNING: architecture specific defines should be avoided
#328: FILE: hw/net/vmxnet3.h:321:
+#ifdef __BIG_ENDIAN_BITFIELD

total: 13 errors, 2 warnings, 441 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org

[Qemu-devel] [PULL 0/6] Net patches

[Jason Wang]

The following changes since commit 2e02083438962d26ef9dcc7100f3b378104183db:

  Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging 
(2017-11-17 19:08:07 +)

are available in the git repository at:

  https://github.com/jasowang/qemu.git tags/net-pull-request

for you to fetch changes up to c527e0afcd7d719abc3a5ca5e4c8ac2fe48b999f:

  hw/net/vmxnet3: Fix code to work on big endian hosts, too (2017-11-20 
11:08:00 +0800)




Ed Swierk (1):
  net: Transmit zero UDP checksum as 0x

Jason Wang (1):
  Revert "Add new PCI ID for i82559a"

Mao Zhongyi (1):
  colo-compare: fix the dangerous assignment

Stefan Weil (1):
  MAINTAINERS: Add missing entry for eepro100 emulation

Thomas Huth (2):
  hw/net/eepro100: Fix endianness problem on big endian hosts
  hw/net/vmxnet3: Fix code to work on big endian hosts, too

 MAINTAINERS|   5 ++
 hw/net/e1000.c |   2 +-
 hw/net/eepro100.c  |  17 +---
 hw/net/net_rx_pkt.c|   2 +-
 hw/net/net_tx_pkt.c|   2 +-
 hw/net/vmware_utils.h  |   6 ++
 hw/net/vmxnet3.c   |  49 ---
 hw/net/vmxnet3.h   | 230 ++---
 include/hw/compat.h|   4 -
 include/hw/pci/pci.h   |   1 -
 include/net/checksum.h |   6 ++
 net/colo-compare.c |   2 +-
 qemu-options.hx|   2 +-
 13 files changed, 201 insertions(+), 127 deletions(-)

Re: [Qemu-devel] [PULL 0/6] Net patches

[Peter Maydell]

On 20 January 2017 at 03:07, Jason Wang  wrote:
> The following changes since commit 0f6bcf68a99efdc531b209551f2b760b0bdcc554:
>
>   Merge remote-tracking branch 'remotes/artyom/tags/pull-sun4v-20170118' into 
> staging (2017-01-19 18:34:13 +)
>
> are available in the git repository at:
>
>   https://github.com/jasowang/qemu.git tags/net-pull-request
>
> for you to fetch changes up to fac7d7b1cdb21f921d7ac396365f5e920ef03096:
>
>   tap: fix memory leak on failure in net_init_tap() (2017-01-20 10:58:26 
> +0800)
>
> 
>

Applied, thanks.

-- PMM

[Qemu-devel] [PULL 0/6] Net patches

[Jason Wang]

The following changes since commit 0f6bcf68a99efdc531b209551f2b760b0bdcc554:

  Merge remote-tracking branch 'remotes/artyom/tags/pull-sun4v-20170118' into 
staging (2017-01-19 18:34:13 +)

are available in the git repository at:

  https://github.com/jasowang/qemu.git tags/net-pull-request

for you to fetch changes up to fac7d7b1cdb21f921d7ac396365f5e920ef03096:

  tap: fix memory leak on failure in net_init_tap() (2017-01-20 10:58:26 +0800)




Alex Kompel (1):
  hw/pci: use-after-free in pci_nic_init_nofail when nic device fails to 
initialize

Ladi Prosek (1):
  net: optimize checksum computation

Peter Maydell (2):
  hw/net/dp8393x: Avoid unintentional sign extensions on addresses
  tap: fix memory leak on failure in net_init_tap()

Thomas Huth (1):
  m68k: QOMify the MCF Fast Ethernet Controller device

Zhang Chen (1):
  docs: Fix description of the sentence

 docs/colo-proxy.txt   |  4 +-
 hw/m68k/mcf5208.c | 25 -
 hw/net/dp8393x.c  | 95 +--
 hw/net/mcf_fec.c  | 71 ++-
 hw/pci/pci.c  |  9 +
 include/hw/m68k/mcf.h |  4 --
 include/hw/m68k/mcf_fec.h | 13 +++
 net/checksum.c| 21 +++
 net/tap.c |  7 +++-
 9 files changed, 180 insertions(+), 69 deletions(-)
 create mode 100644 include/hw/m68k/mcf_fec.h

[Qemu-devel] [PULL 0/6] Net patches

[Stefan Hajnoczi]

The following changes since commit 16017c48547960539fcadb1f91d252124f442482:

  softfloat: Clarify license status (2015-01-29 16:45:45 +)

are available in the git repository at:

  git://github.com/stefanha/qemu.git tags/net-pull-request

for you to fetch changes up to 2c4681f512822b4aa35371683e164d4818f21dce:

  monitor: more accurate completion for host_net_remove() (2015-02-06 14:06:45 
+)





Jason Wang (4):
  monitor: print hub port name during info network
  net: remove the wrong comment in net_init_hubport()
  net: del hub port when peer is deleted
  monitor: more accurate completion for host_net_remove()

Paolo Bonzini (1):
  rtl8139: simplify timer logic

Stefan Hajnoczi (1):
  MAINTAINERS: add Jason Wang as net subsystem maintainer

 MAINTAINERS  |  1 +
 hw/net/rtl8139.c | 77 
 monitor.c|  5 
 net/hub.c|  6 +++--
 net/net.c|  2 ++
 5 files changed, 39 insertions(+), 52 deletions(-)

-- 
2.1.0

Re: [Qemu-devel] [PULL 0/6] Net patches

[Peter Maydell]

On 6 February 2015 at 14:10, Stefan Hajnoczi stefa...@redhat.com wrote:
 The following changes since commit 16017c48547960539fcadb1f91d252124f442482:

   softfloat: Clarify license status (2015-01-29 16:45:45 +)

 are available in the git repository at:

   git://github.com/stefanha/qemu.git tags/net-pull-request

 for you to fetch changes up to 2c4681f512822b4aa35371683e164d4818f21dce:

   monitor: more accurate completion for host_net_remove() (2015-02-06 
 14:06:45 +)

 

 

Applied, thanks.

-- PMM