Re: [Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20

2019-08-20 Thread no-reply
Patchew URL: 
https://patchew.org/QEMU/1566284395-30287-1-git-send-email-pbonz...@redhat.com/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC  hw/display/xenfb.o
  CC  hw/display/vga-pci.o
  CC  hw/display/vga-isa.o
/tmp/qemu-test/src/hw/core/loader.c:1123:9: error: implicit declaration of 
function 'runstate_check' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]
if (runstate_check(RUN_STATE_INMIGRATE))
^
/tmp/qemu-test/src/hw/core/loader.c:1123:9: error: this function declaration is 
not a prototype [-Werror,-Wstrict-prototypes]
2 errors generated.
make: *** [/tmp/qemu-test/src/rules.mak:69: hw/core/loader.o] Error 1
make: *** Waiting for unfinished jobs


The full log is available at
http://patchew.org/logs/1566284395-30287-1-git-send-email-pbonz...@redhat.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com

Re: [Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20

2019-08-20 Thread Peter Maydell
On Tue, 20 Aug 2019 at 08:02, Paolo Bonzini  wrote:
>
> The following changes since commit 864ab314f1d924129d06ac7b571f105a2b76a4b2:
>
>   Update version for v4.1.0-rc4 release (2019-08-06 17:05:21 +0100)
>
> are available in the git repository at:
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 6f93977075ae9971d73879ca872f75e2737f66c5:
>
>   x86: Intel AVX512_BF16 feature enabling (2019-08-20 08:59:18 +0200)
>
> 
> * New KVM PV features (Marcelo, Wanpeng)
> * valgrind fixes (Andrey)
> * Remove clock reset notifiers (David)
> * KConfig and Makefile cleanups (Paolo)
> * Replay and icount improvements (Pavel)
> * x86 FP fixes (Peter M.)
> * TCG locking assertions (Roman)
> * x86 support for mmap-ed -kernel/-initrd (Stefano)
> * Other cleanups (Wei Yang, Yan Zhao, Tony)
> * LSI fix for infinite loop (Prasad)
> * ARM migration fix (Catherine)
> * AVX512_BF16 feature (Jing)
>
> 

Hi; this fails to compile (all platforms):

/home/petmay01/linaro/qemu-for-merges/hw/core/loader.c: In function ‘rom_reset’:
/home/petmay01/linaro/qemu-for-merges/hw/core/loader.c:1123:9: error:
implicit declaration of function ‘runstate_check’; did you mean
‘type_check’? [-Werror=implicit-function-declaration]
 if (runstate_check(RUN_STATE_INMIGRATE))
 ^~
 type_check
/home/petmay01/linaro/qemu-for-merges/hw/core/loader.c:1123:9: error:
nested extern declaration of ‘runstate_check’ [-Werror=nested-externs]
cc1: all warnings being treated as errors
/home/petmay01/linaro/qemu-for-merges/rules.mak:69: recipe for target
'hw/core/loader.o' failed

I suspect the patchset has a semantic conflict with Marcus's
include-cleanup and needs an extra #include somewhere.

thanks
-- PMM



Re: [Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20

2019-08-20 Thread no-reply
Patchew URL: 
https://patchew.org/QEMU/1566284395-30287-1-git-send-email-pbonz...@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20
Message-id: 1566284395-30287-1-git-send-email-pbonz...@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag] 
patchew/1566284395-30287-1-git-send-email-pbonz...@redhat.com -> 
patchew/1566284395-30287-1-git-send-email-pbonz...@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for 
path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) 
registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 
'roms/SLOF'
Submodule 'roms/edk2' (https://git.qemu.org/git/edk2.git) registered for path 
'roms/edk2'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 
'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered 
for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) 
registered for path 'roms/openhackware'
Submodule 'roms/opensbi' (https://git.qemu.org/git/opensbi.git) registered for 
path 'roms/opensbi'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) 
registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for 
path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://git.qemu.org/git/seabios-hppa.git) 
registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for 
path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for 
path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for 
path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) 
registered for path 'roms/u-boot-sam460ex'
Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 
'slirp'
Submodule 'tests/fp/berkeley-softfloat-3' 
(https://git.qemu.org/git/berkeley-softfloat-3.git) registered for path 
'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' 
(https://git.qemu.org/git/berkeley-testfloat-3.git) registered for path 
'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) 
registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out 
'22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out 
'90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 
'ba1ab360eebe6338bb8d7d83a9220ccf7e213af3'
Cloning into 'roms/edk2'...
Submodule path 'roms/edk2': checked out 
'20d2e5a125e34fc8501026613a71549b2a1a3e54'
Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) 
registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'
Submodule 'CryptoPkg/Library/OpensslLib/openssl' 
(https://github.com/openssl/openssl) registered for path 
'CryptoPkg/Library/OpensslLib/openssl'
Cloning into 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'...
Submodule path 'roms/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3': 
checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'CryptoPkg/Library/OpensslLib/openssl'...
Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl': checked out 
'50eaac9f3337667259de725451f201e784599687'
Submodule 'boringssl' (https://boringssl.googlesource.com/boringssl) registered 
for path 'boringssl&#

[Qemu-devel] [PULL 00/36] QEMU patches for 2018-08-20

2019-08-20 Thread Paolo Bonzini
The following changes since commit 864ab314f1d924129d06ac7b571f105a2b76a4b2:

  Update version for v4.1.0-rc4 release (2019-08-06 17:05:21 +0100)

are available in the git repository at:

  git://github.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to 6f93977075ae9971d73879ca872f75e2737f66c5:

  x86: Intel AVX512_BF16 feature enabling (2019-08-20 08:59:18 +0200)


* New KVM PV features (Marcelo, Wanpeng)
* valgrind fixes (Andrey)
* Remove clock reset notifiers (David)
* KConfig and Makefile cleanups (Paolo)
* Replay and icount improvements (Pavel)
* x86 FP fixes (Peter M.)
* TCG locking assertions (Roman)
* x86 support for mmap-ed -kernel/-initrd (Stefano)
* Other cleanups (Wei Yang, Yan Zhao, Tony)
* LSI fix for infinite loop (Prasad)
* ARM migration fix (Catherine)
* AVX512_BF16 feature (Jing)


Andrey Shinkevich (3):
  test-throttle: Fix uninitialized use of burst_length
  tests: Fix uninitialized byte in test_visitor_in_fuzz
  i386/kvm: initialize struct at full before ioctl call

Catherine Ho (1):
  migration: do not rom_reset() during incoming migration

Dr. David Alan Gilbert (4):
  mc146818rtc: Remove reset notifiers
  timer: Remove reset notifiers
  replay: Remove host_clock_last
  timer: last, remove last bits of last

Eduardo Habkost (1):
  HACKING: Document 'struct' keyword usage

Jan Kiszka (1):
  kvm: vmxcap: Enhance with latest features

Jing Liu (1):
  x86: Intel AVX512_BF16 feature enabling

Li Qiang (1):
  target-i386: kvm: 'kvm_get_supported_msrs' cleanup

Marcelo Tosatti (1):
  kvm: i386: halt poll control MSR support

Paolo Bonzini (5):
  block: fix NetBSD qemu-iotests failure
  9p: simplify source file selection
  memory: fix race between TCG and accesses to dirty bitmap
  kconfig: do not select VMMOUSE
  scsi: lsi: exit infinite loop while executing script (CVE-2019-12068)

Pavel Dovgalyuk (8):
  replay: add missing fix for internal function
  replay: document development rules
  util/qemu-timer: refactor deadline calculation for external timers
  replay: fix replay shutdown
  replay: refine replay-time module
  replay: rename step-related variables and functions
  icount: clean up cpu_can_io at the entry to the block
  icount: remove unnecessary gen_io_end calls

Peter Maydell (1):
  target/i386: Return 'indefinite integer value' for invalid SSE fp->int 
conversions

Roman Kagan (2):
  cpus-common: nuke finish_safe_work
  cpus-common: assert BQL nesting within cpu-exclusive sections

Stefano Garzarella (3):
  loader: Handle memory-mapped ELFs
  elf-ops.h: Map into memory the ELF to load
  hw/i386/pc: Map into memory the initrd

Wanpeng Li (1):
  target-i386: adds PV_SCHED_YIELD CPUID feature bit

Wei Yang (1):
  test-bitmap: test set 1 bit case for bitmap_set

Yan Zhao (1):
  memory: assert on out of scope notification

tony.ngu...@bt.com (1):
  configure: Define target access alignment in configure

 HACKING |  14 +-
 Kconfig.host|   1 +
 accel/tcg/cpu-exec.c|   1 -
 accel/tcg/translator.c  |   1 -
 block/file-posix.c  |   4 +-
 configure   |  12 +-
 cpus-common.c   |  12 +-
 cpus.c  |  17 ++-
 docs/devel/replay.txt   |  46 +++
 exec.c  |  31 +
 fsdev/Makefile.objs |   2 +-
 hw/9pfs/Kconfig |   5 +
 hw/core/loader.c|  47 +--
 hw/i386/Kconfig |   1 +
 hw/i386/pc.c|  17 ++-
 hw/scsi/lsi53c895a.c|  41 --
 hw/timer/mc146818rtc.c  |  19 ---
 include/exec/gen-icount.h   |  44 +++---
 include/exec/memory.h   |  12 ++
 include/exec/poison.h   |   1 +
 include/hw/elf_ops.h|  71 ++
 include/hw/i386/pc.h|   1 +
 include/hw/loader.h |   5 +-
 include/qemu/timer.h|  43 +-
 include/qom/cpu.h   |   2 +-
 include/standard-headers/asm-x86/kvm_para.h |   2 +
 include/sysemu/replay.h |   2 +-
 memory.c|  16 ++-
 migration/ram.c |   1 +
 qtest.c |   3 +-
 replay/replay-events.c  |   2 +-
 replay/replay-internal.c|  10 +-
 replay/replay-internal.h|  10 +-
 replay/replay-snap