Re: [Qemu-devel] [RFC 00/15] s390: vfio-ccw dasd ipl support
On Tue, 21 Aug 2018 15:31:55 -0400 "Jason J. Herne" wrote: > On 08/15/2018 07:48 AM, Cornelia Huck wrote: > > On Thu, 5 Jul 2018 13:25:28 -0400 > > "Jason J. Herne" wrote: > > > >> This is to support booting from vfio-ccw dasd devices. We basically > >> implement > >> the real hardware ipl procedure. This allows for booting Linux guests on > >> vfio-ccw devices. > >> > >> vfio-ccw's channel program prefetch algorithm complicates ipl because most > >> ipl > >> channel programs dynamically modify themselves. Details on the ipl process > >> and > >> how we worked around this issue can be found in > >> docs/devel/s390-dasd-ipl.txt. > > > > Cleaning up my mail backlog... I think there were some comments; will > > there be a new version forthcoming? > > > > Yes there will. We're hitting a hang now and not sure if it is a device, > configuration or coding problem. Once I get that cleared up I'll be back > for round #2. > Great, thanks for the info!
Re: [Qemu-devel] [RFC 00/15] s390: vfio-ccw dasd ipl support
On 08/15/2018 07:48 AM, Cornelia Huck wrote: On Thu, 5 Jul 2018 13:25:28 -0400 "Jason J. Herne" wrote: This is to support booting from vfio-ccw dasd devices. We basically implement the real hardware ipl procedure. This allows for booting Linux guests on vfio-ccw devices. vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl channel programs dynamically modify themselves. Details on the ipl process and how we worked around this issue can be found in docs/devel/s390-dasd-ipl.txt. Cleaning up my mail backlog... I think there were some comments; will there be a new version forthcoming? Yes there will. We're hitting a hang now and not sure if it is a device, configuration or coding problem. Once I get that cleared up I'll be back for round #2. -- -- Jason J. Herne (jjhe...@linux.ibm.com)
Re: [Qemu-devel] [RFC 00/15] s390: vfio-ccw dasd ipl support
On Thu, 5 Jul 2018 13:25:28 -0400 "Jason J. Herne" wrote: > This is to support booting from vfio-ccw dasd devices. We basically implement > the real hardware ipl procedure. This allows for booting Linux guests on > vfio-ccw devices. > > vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl > channel programs dynamically modify themselves. Details on the ipl process and > how we worked around this issue can be found in docs/devel/s390-dasd-ipl.txt. Cleaning up my mail backlog... I think there were some comments; will there be a new version forthcoming?
Re: [Qemu-devel] [RFC 00/15] s390: vfio-ccw dasd ipl support
On Thu, 5 Jul 2018 13:25:28 -0400 "Jason J. Herne" wrote: > This is to support booting from vfio-ccw dasd devices. We basically implement > the real hardware ipl procedure. This allows for booting Linux guests on > vfio-ccw devices. Wow :) > > vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl > channel programs dynamically modify themselves. Details on the ipl process and > how we worked around this issue can be found in docs/devel/s390-dasd-ipl.txt. Yes, that must have been a challenge. Does this work with any dasd? Or did you concentrate on ECKD? (yeah, I'll also read what you sent :) > > Jason J. Herne (15): > s390 vfio-ccw: Add bootindex property and IPLB data > s390-bios: decouple cio setup from virtio > s390-bios: decouple common boot logic from virtio > s390-bios: Extend find_dev() for non-virtio devices > s390-bios: Factor finding boot device out of virtio code path > s390-bios: Clean up cio.h > s390-bios: Decouple channel i/o logic from virtio > s390-bios: Map low core memory > s390-bios: ptr2u32 and u32toptr > s390-bios: Support for running format-0/1 channel programs > s390-bios: Refactor virtio to run channel programs via cio > s390-bios: Use control unit type to determine boot method > s390-bios: Add channel command codes/structs needed for dasd-ipl > s390-bios: Support booting from real dasd device > s390-bios: Use sense ccw to ensure consistent device state at boot > time > > docs/devel/s390-dasd-ipl.txt | 132 + > hw/s390x/ipl.c | 15 +++ > hw/s390x/s390-ccw.c | 9 ++ > hw/vfio/ccw.c| 13 +- > hw/vfio/ccw.h| 38 ++ > include/hw/s390x/s390-ccw.h | 1 + > pc-bios/s390-ccw/Makefile| 2 +- > pc-bios/s390-ccw/cio.c | 181 > pc-bios/s390-ccw/cio.h | 150 --- > pc-bios/s390-ccw/dasd-ipl.c | 249 > +++ > pc-bios/s390-ccw/dasd-ipl.h | 16 +++ > pc-bios/s390-ccw/libc.h | 12 ++ > pc-bios/s390-ccw/main.c | 162 - > pc-bios/s390-ccw/netmain.c | 1 + > pc-bios/s390-ccw/s390-arch.h | 113 ++ > pc-bios/s390-ccw/s390-ccw.h | 9 -- > pc-bios/s390-ccw/virtio-blkdev.c | 1 + > pc-bios/s390-ccw/virtio.c| 46 +--- > 18 files changed, 986 insertions(+), 164 deletions(-) > create mode 100644 docs/devel/s390-dasd-ipl.txt > create mode 100644 hw/vfio/ccw.h > create mode 100644 pc-bios/s390-ccw/cio.c > create mode 100644 pc-bios/s390-ccw/dasd-ipl.c > create mode 100644 pc-bios/s390-ccw/dasd-ipl.h > create mode 100644 pc-bios/s390-ccw/s390-arch.h >
Re: [Qemu-devel] [RFC 00/15] s390: vfio-ccw dasd ipl support
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1530811543-6881-1-git-send-email-jjhe...@linux.ibm.com Subject: [Qemu-devel] [RFC 00/15] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1530811543-6881-1-git-send-email-jjhe...@linux.ibm.com -> patchew/1530811543-6881-1-git-send-email-jjhe...@linux.ibm.com * [new tag] patchew/20180705181148.26871-1-...@kaod.org -> patchew/20180705181148.26871-1-...@kaod.org Switched to a new branch 'test' 6785986a44 s390-bios: Use sense ccw to ensure consistent device state at boot time 9b846d6380 s390-bios: Support booting from real dasd device c74078bbf2 s390-bios: Add channel command codes/structs needed for dasd-ipl 496a1dd198 s390-bios: Use control unit type to determine boot method 661349b875 s390-bios: Refactor virtio to run channel programs via cio 6d542cb2d3 s390-bios: Support for running format-0/1 channel programs 288218e34b s390-bios: ptr2u32 and u32toptr 5a983fa548 s390-bios: Map low core memory 6ac319135b s390-bios: Decouple channel i/o logic from virtio c6cff32792 s390-bios: Clean up cio.h 3c10f3a8b0 s390-bios: Factor finding boot device out of virtio code path 37db552244 s390-bios: Extend find_dev() for non-virtio devices f6324f4db1 s390-bios: decouple common boot logic from virtio ad9aa692ac s390-bios: decouple cio setup from virtio b05e736bac s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === Checking PATCH 1/15: s390 vfio-ccw: Add bootindex property and IPLB data... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #120: new file mode 100644 total: 0 errors, 1 warnings, 131 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/15: s390-bios: decouple cio setup from virtio... Checking PATCH 3/15: s390-bios: decouple common boot logic from virtio... ERROR: externs should be avoided in .c files #28: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/15: s390-bios: Extend find_dev() for non-virtio devices... Checking PATCH 5/15: s390-bios: Factor finding boot device out of virtio code path... Checking PATCH 6/15: s390-bios: Clean up cio.h... ERROR: spaces prohibited around that ':' (ctx:WxW) #28: FILE: pc-bios/s390-ccw/cio.h:56: +__u32 isc: 3; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #29: FILE: pc-bios/s390-ccw/cio.h:57: +__u32 ena: 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #30: FILE: pc-bios/s390-ccw/cio.h:58: +__u32 mme: 2; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #31: FILE: pc-bios/s390-ccw/cio.h:59: +__u32 mp : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #32: FILE: pc-bios/s390-ccw/cio.h:60: +__u32 csense : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #33: FILE: pc-bios/s390-ccw/cio.h:61: +__u32 mbfc : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #83: FILE: pc-bios/s390-ccw/cio.h:111: +__u32 reserved5 : 4; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #84: FILE: pc-bios/s390-ccw/cio.h:112: +__u32 format2 : 4; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #85: FILE: pc-bios/s390-ccw/cio.h:113: +__u32 reserved6 : 24; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #131: FILE: pc-bios/s390-ccw/cio.h:167: +__u32 key : 4; /* flags, like key, suspend control, etc. */ ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #132: FILE: pc-bios/s390-ccw/cio.h:168: +__u32 spnd : 1; /* suspend control */ ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #133: FILE:
[Qemu-devel] [RFC 00/15] s390: vfio-ccw dasd ipl support
This is to support booting from vfio-ccw dasd devices. We basically implement the real hardware ipl procedure. This allows for booting Linux guests on vfio-ccw devices. vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl channel programs dynamically modify themselves. Details on the ipl process and how we worked around this issue can be found in docs/devel/s390-dasd-ipl.txt. Jason J. Herne (15): s390 vfio-ccw: Add bootindex property and IPLB data s390-bios: decouple cio setup from virtio s390-bios: decouple common boot logic from virtio s390-bios: Extend find_dev() for non-virtio devices s390-bios: Factor finding boot device out of virtio code path s390-bios: Clean up cio.h s390-bios: Decouple channel i/o logic from virtio s390-bios: Map low core memory s390-bios: ptr2u32 and u32toptr s390-bios: Support for running format-0/1 channel programs s390-bios: Refactor virtio to run channel programs via cio s390-bios: Use control unit type to determine boot method s390-bios: Add channel command codes/structs needed for dasd-ipl s390-bios: Support booting from real dasd device s390-bios: Use sense ccw to ensure consistent device state at boot time docs/devel/s390-dasd-ipl.txt | 132 + hw/s390x/ipl.c | 15 +++ hw/s390x/s390-ccw.c | 9 ++ hw/vfio/ccw.c| 13 +- hw/vfio/ccw.h| 38 ++ include/hw/s390x/s390-ccw.h | 1 + pc-bios/s390-ccw/Makefile| 2 +- pc-bios/s390-ccw/cio.c | 181 pc-bios/s390-ccw/cio.h | 150 --- pc-bios/s390-ccw/dasd-ipl.c | 249 +++ pc-bios/s390-ccw/dasd-ipl.h | 16 +++ pc-bios/s390-ccw/libc.h | 12 ++ pc-bios/s390-ccw/main.c | 162 - pc-bios/s390-ccw/netmain.c | 1 + pc-bios/s390-ccw/s390-arch.h | 113 ++ pc-bios/s390-ccw/s390-ccw.h | 9 -- pc-bios/s390-ccw/virtio-blkdev.c | 1 + pc-bios/s390-ccw/virtio.c| 46 +--- 18 files changed, 986 insertions(+), 164 deletions(-) create mode 100644 docs/devel/s390-dasd-ipl.txt create mode 100644 hw/vfio/ccw.h create mode 100644 pc-bios/s390-ccw/cio.c create mode 100644 pc-bios/s390-ccw/dasd-ipl.c create mode 100644 pc-bios/s390-ccw/dasd-ipl.h create mode 100644 pc-bios/s390-ccw/s390-arch.h -- 2.7.4
