Re: [Qemu-devel] regression in timer code?

2018-03-15 Thread Max Filippov
On Wed, Mar 14, 2018 at 11:09 PM, Pavel Dovgalyuk wrote: >> From: Max Filippov [mailto:jcmvb...@gmail.com] >> On Wed, Mar 14, 2018 at 2:53 AM, Pavel Dovgalyuk wrote: >> > icount is adjusted by icount_warp_rt when CPU sleeps. >> > These adjustments may be

Re: [Qemu-devel] regression in timer code?

2018-03-15 Thread Pavel Dovgalyuk
> From: Max Filippov [mailto:jcmvb...@gmail.com] > On Wed, Mar 14, 2018 at 2:53 AM, Pavel Dovgalyuk wrote: > > icount is adjusted by icount_warp_rt when CPU sleeps. > > These adjustments may be different in different runs. > > And the first adjustment is performed at the start

Re: [Qemu-devel] regression in timer code?

2018-03-14 Thread Max Filippov
On Wed, Mar 14, 2018 at 2:53 AM, Pavel Dovgalyuk wrote: > icount is adjusted by icount_warp_rt when CPU sleeps. > These adjustments may be different in different runs. > And the first adjustment is performed at the start of the machine. > Therefore "now" value includes

Re: [Qemu-devel] regression in timer code?

2018-03-14 Thread Pavel Dovgalyuk
> -Original Message- > From: Max Filippov [mailto:jcmvb...@gmail.com] > Sent: Wednesday, March 14, 2018 12:41 PM > To: Pavel Dovgalyuk > Cc: Pavel Dovgaluk; qemu-devel > Subject: Re: regression in timer code? > > On Wed, Mar 14, 2018 at 2:07 AM, Pavel Dovgalyuk

Re: [Qemu-devel] regression in timer code?

2018-03-14 Thread Max Filippov
On Wed, Mar 14, 2018 at 2:07 AM, Pavel Dovgalyuk wrote: >> From: Max Filippov [mailto:jcmvb...@gmail.com] >> the commit b39e3f34c9de7ead6a11a74aa2de78baf41d81a7 >> ("icount: fixed saving/restoring of icount warp timers") has changed >> something that made timers test for

Re: [Qemu-devel] regression in timer code?

2018-03-14 Thread Pavel Dovgalyuk
> From: Max Filippov [mailto:jcmvb...@gmail.com] > the commit b39e3f34c9de7ead6a11a74aa2de78baf41d81a7 > ("icount: fixed saving/restoring of icount warp timers") has changed > something that made timers test for target/xtensa unstable. > Specifically ccount_write case in the

[Qemu-devel] regression in timer code?

2018-03-13 Thread Max Filippov
Hi Pavel, the commit b39e3f34c9de7ead6a11a74aa2de78baf41d81a7 ("icount: fixed saving/restoring of icount warp timers") has changed something that made timers test for target/xtensa unstable. Specifically ccount_write case in the tests/tcg/xtensa/test_timer.S now fails for me about half of the