Re: [RFC v5 010/126] hw/core/qdev: cleanup Error ** variables

2019-11-08 Thread Marc-André Lureau
On Fri, Oct 11, 2019 at 8:18 PM Vladimir Sementsov-Ogievskiy wrote: > > Rename Error ** parameter in check_only_migratable to common errp. > > In device_set_realized: > > - Move "if (local_err != NULL)" closer to error setters. > > - Drop 'Error **local_errp': it doesn't save any LoCs, but it's

Re: [RFC v5 010/126] hw/core/qdev: cleanup Error ** variables

2019-10-11 Thread Eric Blake
On 10/11/19 11:03 AM, Vladimir Sementsov-Ogievskiy wrote: Rename Error ** parameter in check_only_migratable to common errp. In device_set_realized: - Move "if (local_err != NULL)" closer to error setters. - Drop 'Error **local_errp': it doesn't save any LoCs, but it's very unusual.

[RFC v5 010/126] hw/core/qdev: cleanup Error ** variables

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
Rename Error ** parameter in check_only_migratable to common errp. In device_set_realized: - Move "if (local_err != NULL)" closer to error setters. - Drop 'Error **local_errp': it doesn't save any LoCs, but it's very unusual. Signed-off-by: Vladimir Sementsov-Ogievskiy ---