RE: [EXT] Re: [PATCHv3 00/13] Adding comprehensive support for i.MX8MM EVK board
> -Original Message- > From: Peter Maydell > Sent: 02 December 2025 15:14 > To: Gaurav Sharma > Cc: [email protected]; [email protected] > Subject: Re: [EXT] Re: [PATCHv3 00/13] Adding comprehensive support for > i.MX8MM EVK board > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On Tue, 2 Dec 2025 at 05:19, Gaurav Sharma > wrote: > > > > > > > At least some of these patches were reviewed by Philippe in v1. > > > Did they all change? > > > > > > The way this is supposed to work is that where a patch has been > > > reviewed and hasn't changed in a followup respin of a patchset, you > > > keep the reviewed-by tag, which tells us that we don't need to > > > repeat that bit of the review. More detail: > > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww > > > > w.q%2F&data=05%7C02%7Cgaurav.sharma_7%40nxp.com%7C5426ed39023f > 453ab8 > > > > 5908de31875150%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63 > 900265 > > > > 4453250191%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIl > YiOiIwL > > > > jAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7 > C%7 > > > > C%7C&sdata=5MI2GF5C0W%2Fwuyoysgtn4m%2BZQSMrEALcRtZhTxjchcs%3D > &reserv > > > ed=0 > > > emu.org%2Fdocs%2Fmaster%2Fdevel%2Fsubmitting-a- > patch.html%23proper- > > > use-of-reviewed-by-tags-can-aid- > > > > review&data=05%7C02%7Cgaurav.sharma_7%40nxp.com%7C7d7d9203ac334 > > > > 65757c908de3116f632%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0% > > > > 7C639002171850292201%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGki > > > > OnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoy > > > > fQ%3D%3D%7C0%7C%7C%7C&sdata=%2Bj2Q4APWnTNTY%2FTHqfaEZsmBJH > > > E%2FzD6zsv%2BxnZ9IyC4%3D&reserved=0 > > > > > > > The v1 patch files reviewed by Philippe changed. Structure type was > changed in all those reviewed patches that's why reviewed-by tag was not > retained in the follow-up revisions. > > Generally, if somebody says "do this trivial change X" > and then gives an R-by tag, they mean "if you do this thing and nothing else > then you can add my tag to it". > Got it.
Re: [EXT] Re: [PATCHv3 00/13] Adding comprehensive support for i.MX8MM EVK board
On Tue, 2 Dec 2025 at 05:19, Gaurav Sharma wrote: > > > > At least some of these patches were reviewed by Philippe in v1. > > Did they all change? > > > > The way this is supposed to work is that where a patch has been reviewed > > and hasn't changed in a followup respin of a patchset, you keep the > > reviewed-by tag, which tells us that we don't need to repeat that bit of the > > review. More detail: > > > > https://www.q/ > > emu.org%2Fdocs%2Fmaster%2Fdevel%2Fsubmitting-a-patch.html%23proper- > > use-of-reviewed-by-tags-can-aid- > > review&data=05%7C02%7Cgaurav.sharma_7%40nxp.com%7C7d7d9203ac334 > > 65757c908de3116f632%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0% > > 7C639002171850292201%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGki > > OnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoy > > fQ%3D%3D%7C0%7C%7C%7C&sdata=%2Bj2Q4APWnTNTY%2FTHqfaEZsmBJH > > E%2FzD6zsv%2BxnZ9IyC4%3D&reserved=0 > > > > The v1 patch files reviewed by Philippe changed. Structure type was changed > in all those reviewed patches that's why reviewed-by tag was not retained in > the follow-up revisions. Generally, if somebody says "do this trivial change X" and then gives an R-by tag, they mean "if you do this thing and nothing else then you can add my tag to it". thanks -- PMM
RE: [EXT] Re: [PATCHv3 00/13] Adding comprehensive support for i.MX8MM EVK board
> At least some of these patches were reviewed by Philippe in v1. > Did they all change? > > The way this is supposed to work is that where a patch has been reviewed > and hasn't changed in a followup respin of a patchset, you keep the > reviewed-by tag, which tells us that we don't need to repeat that bit of the > review. More detail: > > https://www.q/ > emu.org%2Fdocs%2Fmaster%2Fdevel%2Fsubmitting-a-patch.html%23proper- > use-of-reviewed-by-tags-can-aid- > review&data=05%7C02%7Cgaurav.sharma_7%40nxp.com%7C7d7d9203ac334 > 65757c908de3116f632%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0% > 7C639002171850292201%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGki > OnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoy > fQ%3D%3D%7C0%7C%7C%7C&sdata=%2Bj2Q4APWnTNTY%2FTHqfaEZsmBJH > E%2FzD6zsv%2BxnZ9IyC4%3D&reserved=0 > The v1 patch files reviewed by Philippe changed. Structure type was changed in all those reviewed patches that's why reviewed-by tag was not retained in the follow-up revisions.
