Re: [PATCH] migration/throttle: Make throttle slower at tail stage

2020-02-18 Thread zhukeqian
On 2020/2/14 20:28, Dr. David Alan Gilbert wrote: > * Keqian Zhu (zhukeqi...@huawei.com) wrote: >> At the tail stage of throttle, VM is very sensitive to >> CPU percentage. We just throttle 30% of remaining CPU >> when throttle is more than 80 percentage. > > This is a bit unusual; all of the

Re: [PATCH] migration/throttle: Make throttle slower at tail stage

2020-02-18 Thread zhukeqian
On 2020/2/14 19:46, Eric Blake wrote: > On 2/13/20 9:27 PM, Keqian Zhu wrote: >> At the tail stage of throttle, VM is very sensitive to >> CPU percentage. We just throttle 30% of remaining CPU >> when throttle is more than 80 percentage. >> >> This doesn't conflict with cpu_throttle_increment.

Re: [PATCH] migration/throttle: Make throttle slower at tail stage

2020-02-18 Thread zhukeqian
Hi, Juan On 2020/2/14 20:37, Juan Quintela wrote: > Keqian Zhu wrote: >> At the tail stage of throttle, VM is very sensitive to >> CPU percentage. We just throttle 30% of remaining CPU >> when throttle is more than 80 percentage. > > Why? > My original idea is that if we throttle a fixed

Re: [PATCH] migration/throttle: Make throttle slower at tail stage

2020-02-14 Thread Juan Quintela
Keqian Zhu wrote: > At the tail stage of throttle, VM is very sensitive to > CPU percentage. We just throttle 30% of remaining CPU > when throttle is more than 80 percentage. Why? If we really think that this is better that current approarch, just do this _always_. And throothre 30% of

Re: [PATCH] migration/throttle: Make throttle slower at tail stage

2020-02-14 Thread Dr. David Alan Gilbert
* Keqian Zhu (zhukeqi...@huawei.com) wrote: > At the tail stage of throttle, VM is very sensitive to > CPU percentage. We just throttle 30% of remaining CPU > when throttle is more than 80 percentage. This is a bit unusual; all of the rest of the throttling has no fixed constants; all values are

Re: [PATCH] migration/throttle: Make throttle slower at tail stage

2020-02-14 Thread Eric Blake
On 2/13/20 9:27 PM, Keqian Zhu wrote: At the tail stage of throttle, VM is very sensitive to CPU percentage. We just throttle 30% of remaining CPU when throttle is more than 80 percentage. This doesn't conflict with cpu_throttle_increment. This may make migration time longer, and is disabled