Re: [PATCH] target/arm: Rearrange cpu64.c so all the CPU initfns are together
On 12/8/22 19:41, Peter Maydell wrote: cpu64.c has ended up in a slightly odd order -- it starts with the initfns for most of the models-real-hardware CPUs; after that comes a bunch of support code for SVE, SME, pauth and LPA2 properties. Then come the initfns for the 'host' and 'max' CPU types, and then after that one more models-real-hardware CPU initfn, for a64fx. (This ordering is partly historical and partly required because a64fx needs the SVE properties.) Reorder the file into: * CPU property support functions * initfns for real hardware CPUs * initfns for host and max * class boilerplate Signed-off-by: Peter Maydell --- I started off thinking this would be a relatively simple "move the a64fx initfn up to live with the others", but because we effectively have to move all the cpu initfns the diffstat has ended up quite big. On the other hand this patch is purely code motion, and the resulting order in the file does seem to me to be more sensible. --- target/arm/cpu64.c | 712 ++--- 1 file changed, 356 insertions(+), 356 deletions(-) Reviewed-by: Philippe Mathieu-Daudé
Re: [PATCH] target/arm: Rearrange cpu64.c so all the CPU initfns are together
On 8/12/22 10:41, Peter Maydell wrote: cpu64.c has ended up in a slightly odd order -- it starts with the initfns for most of the models-real-hardware CPUs; after that comes a bunch of support code for SVE, SME, pauth and LPA2 properties. Then come the initfns for the 'host' and 'max' CPU types, and then after that one more models-real-hardware CPU initfn, for a64fx. (This ordering is partly historical and partly required because a64fx needs the SVE properties.) Reorder the file into: * CPU property support functions * initfns for real hardware CPUs * initfns for host and max * class boilerplate Signed-off-by: Peter Maydell --- I started off thinking this would be a relatively simple "move the a64fx initfn up to live with the others", but because we effectively have to move all the cpu initfns the diffstat has ended up quite big. On the other hand this patch is purely code motion, and the resulting order in the file does seem to me to be more sensible. --- target/arm/cpu64.c | 712 ++--- 1 file changed, 356 insertions(+), 356 deletions(-) Reviewed-by: Richard Henderson r~