Re: [PATCH] target/i386: reimplement fpatan using floatx80 operations
Testing with the glibc testsuite shows this patch needs a little more work to get correct underflow/inexact exceptions in the case where ST0 is positive and ST1/ST0 is small. I'll send a revised patch next week (I don't expect any changes in the rest of the code). -- Joseph S. Myers jos...@codesourcery.com
Re: [PATCH] target/i386: reimplement fpatan using floatx80 operations
Patchew URL: https://patchew.org/QEMU/alpine.deb.2.21.2006192003370.30...@digraph.polyomino.org.uk/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 === TEST SCRIPT END === CC qga/commands.o CC qga/guest-agent-command-state.o CC qga/main.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) CC qga/commands-posix.o CC qga/channel-posix.o CC qga/qapi-generated/qga-qapi-types.o --- GEN docs/interop/qemu-ga-ref.html GEN docs/interop/qemu-ga-ref.txt GEN docs/interop/qemu-ga-ref.7 /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-keymap LINKivshmem-client /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKivshmem-server /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-nbd LINKqemu-storage-daemon /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-io /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-edid /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) AS pc-bios/optionrom/multiboot.o LINKfsdev/virtfs-proxy-helper AS pc-bios/optionrom/linuxboot.o CC pc-bios/optionrom/linuxboot_dma.o LINKscsi/qemu-pr-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) AS pc-bios/optionrom/kvmvapic.o AS pc-bios/optionrom/pvh.o CC pc-bios/optionrom/pvh_main.o LINKqemu-bridge-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) BUILD pc-bios/optionrom/multiboot.img BUILD pc-bios/optionrom/linuxboot.img BUILD pc-bios/optionrom/linuxboot_dma.img BUILD pc-bios/optionrom/kvmvapic.img /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) BUILD pc-bios/optionrom/multiboot.raw BUILD pc-bios/optionrom/pvh.img BUILD pc-bios/optionrom/linuxboot.raw --- SIGNpc-bios/optionrom/linuxboot_dma.bin SIGNpc-bios/optionrom/kvmvapic.bin SIGNpc-bios/optionrom/pvh.bin /usr/bin/ld:
Re: [PATCH] target/i386: reimplement fpatan using floatx80 operations
On Fri, 19 Jun 2020, no-re...@patchew.org wrote: > This series seems to have some coding style problems. See output below for > more information: This is the same issues as before of this patch checker not understanding hex float constants, and it not seeming particularly useful to wrap lines in a large table of randomly generated tests. -- Joseph S. Myers jos...@codesourcery.com
Re: [PATCH] target/i386: reimplement fpatan using floatx80 operations
Patchew URL: https://patchew.org/QEMU/alpine.deb.2.21.2006192003370.30...@digraph.polyomino.org.uk/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 === TEST SCRIPT END === CC aarch64-softmmu/qapi/qapi-commands.o CC aarch64-softmmu/qapi/qapi-init-commands.o /tmp/qemu-test/src/target/i386/fpu_helper.c: In function 'helper_fpatan': /tmp/qemu-test/src/target/i386/fpu_helper.c:1072:17: error: implicit declaration of function 'shift128Right' [-Werror=implicit-function-declaration] shift128Right(remsig0, remsig1, 1, , ); ^ /tmp/qemu-test/src/target/i386/fpu_helper.c:1072:17: error: nested extern declaration of 'shift128Right' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1075:13: error: implicit declaration of function 'estimateDiv128To64' [-Werror=implicit-function-declaration] xsig0 = estimateDiv128To64(remsig0, remsig1, den_sig); ^ /tmp/qemu-test/src/target/i386/fpu_helper.c:1075:13: error: nested extern declaration of 'estimateDiv128To64' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1076:13: error: implicit declaration of function 'mul64To128' [-Werror=implicit-function-declaration] mul64To128(den_sig, xsig0, , ); ^ /tmp/qemu-test/src/target/i386/fpu_helper.c:1076:13: error: nested extern declaration of 'mul64To128' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1077:13: error: implicit declaration of function 'sub128' [-Werror=implicit-function-declaration] sub128(remsig0, remsig1, msig0, msig1, , ); ^ /tmp/qemu-test/src/target/i386/fpu_helper.c:1077:13: error: nested extern declaration of 'sub128' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1080:17: error: implicit declaration of function 'add128' [-Werror=implicit-function-declaration] add128(remsig0, remsig1, 0, den_sig, , ); ^ /tmp/qemu-test/src/target/i386/fpu_helper.c:1080:17: error: nested extern declaration of 'add128' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1117:33: error: implicit declaration of function 'shift128Left' [-Werror=implicit-function-declaration] shift128Left(ysig0, ysig1, shift, ^ /tmp/qemu-test/src/target/i386/fpu_helper.c:1117:33: error: nested extern declaration of 'shift128Left' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1145:21: error: implicit declaration of function 'shift128RightJamming' [-Werror=implicit-function-declaration] shift128RightJamming(xsig0, xsig1, texp - xexp, ^ /tmp/qemu-test/src/target/i386/fpu_helper.c:1145:21: error: nested extern declaration of 'shift128RightJamming' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1174:17: error: implicit declaration of function 'mul128By64To192' [-Werror=implicit-function-declaration] mul128By64To192(xsig0, xsig1, tsig, , , ); ^ /tmp/qemu-test/src/target/i386/fpu_helper.c:1174:17: error: nested extern declaration of 'mul128By64To192' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1192:17: error: implicit declaration of function 'sub192' [-Werror=implicit-function-declaration] sub192(remsig0, remsig1, remsig2, msig0, msig1, msig2, ^ /tmp/qemu-test/src/target/i386/fpu_helper.c:1192:17: error: nested extern declaration of 'sub192' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1196:21: error: implicit declaration of function 'add192' [-Werror=implicit-function-declaration] add192(remsig0, remsig1, remsig2, 0, dsig0, dsig1, ^ /tmp/qemu-test/src/target/i386/fpu_helper.c:1196:21: error: nested extern declaration of 'add192' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1211:17: error: implicit declaration of function 'mul128To256' [-Werror=implicit-function-declaration] mul128To256(zsig0, zsig1, zsig0, zsig1, ^ /tmp/qemu-test/src/target/i386/fpu_helper.c:1211:17: error: nested extern declaration of 'mul128To256' [-Werror=nested-externs] cc1: all warnings being treated as errors make[1]: *** [target/i386/fpu_helper.o] Error 1 make: *** [x86_64-softmmu/all] Error 2 make: *** Waiting for unfinished jobs CC aarch64-softmmu/softmmu/vl.o CC aarch64-softmmu/target/arm/arm-semi.o --- raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label',
Re: [PATCH] target/i386: reimplement fpatan using floatx80 operations
On Fri, 19 Jun 2020, no-re...@patchew.org wrote: > This series failed the docker-mingw@fedora build test. Please find the > testing commands and their output below. If you have Docker installed, > you can probably reproduce it locally. This is because the patch depends on my previous patch to reimplement f2xm1, which adds an include of fpu/softfloat-macros.h to target/i386/fpu_helper.c. -- Joseph S. Myers jos...@codesourcery.com
Re: [PATCH] target/i386: reimplement fpatan using floatx80 operations
Patchew URL: https://patchew.org/QEMU/alpine.deb.2.21.2006192003370.30...@digraph.polyomino.org.uk/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #! /bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-mingw@fedora J=14 NETWORK=1 === TEST SCRIPT END === CC aarch64-softmmu/trace/generated-helpers.o LINKaarch64-softmmu/qemu-system-aarch64w.exe /tmp/qemu-test/src/target/i386/fpu_helper.c: In function 'helper_fpatan': /tmp/qemu-test/src/target/i386/fpu_helper.c:1072:17: error: implicit declaration of function 'shift128Right' [-Werror=implicit-function-declaration] 1072 | shift128Right(remsig0, remsig1, 1, , ); | ^ /tmp/qemu-test/src/target/i386/fpu_helper.c:1072:17: error: nested extern declaration of 'shift128Right' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1075:21: error: implicit declaration of function 'estimateDiv128To64' [-Werror=implicit-function-declaration] 1075 | xsig0 = estimateDiv128To64(remsig0, remsig1, den_sig); | ^~ /tmp/qemu-test/src/target/i386/fpu_helper.c:1075:21: error: nested extern declaration of 'estimateDiv128To64' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1076:13: error: implicit declaration of function 'mul64To128' [-Werror=implicit-function-declaration] 1076 | mul64To128(den_sig, xsig0, , ); | ^~ /tmp/qemu-test/src/target/i386/fpu_helper.c:1076:13: error: nested extern declaration of 'mul64To128' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1077:13: error: implicit declaration of function 'sub128' [-Werror=implicit-function-declaration] 1077 | sub128(remsig0, remsig1, msig0, msig1, , ); | ^~ /tmp/qemu-test/src/target/i386/fpu_helper.c:1077:13: error: nested extern declaration of 'sub128' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1080:17: error: implicit declaration of function 'add128' [-Werror=implicit-function-declaration] 1080 | add128(remsig0, remsig1, 0, den_sig, , ); | ^~ /tmp/qemu-test/src/target/i386/fpu_helper.c:1080:17: error: nested extern declaration of 'add128' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1117:33: error: implicit declaration of function 'shift128Left' [-Werror=implicit-function-declaration] 1117 | shift128Left(ysig0, ysig1, shift, | ^~~~ /tmp/qemu-test/src/target/i386/fpu_helper.c:1117:33: error: nested extern declaration of 'shift128Left' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1145:21: error: implicit declaration of function 'shift128RightJamming' [-Werror=implicit-function-declaration] 1145 | shift128RightJamming(xsig0, xsig1, texp - xexp, | ^~~~ /tmp/qemu-test/src/target/i386/fpu_helper.c:1145:21: error: nested extern declaration of 'shift128RightJamming' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1174:17: error: implicit declaration of function 'mul128By64To192' [-Werror=implicit-function-declaration] 1174 | mul128By64To192(xsig0, xsig1, tsig, , , ); | ^~~ /tmp/qemu-test/src/target/i386/fpu_helper.c:1174:17: error: nested extern declaration of 'mul128By64To192' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1192:17: error: implicit declaration of function 'sub192' [-Werror=implicit-function-declaration] 1192 | sub192(remsig0, remsig1, remsig2, msig0, msig1, msig2, | ^~ /tmp/qemu-test/src/target/i386/fpu_helper.c:1192:17: error: nested extern declaration of 'sub192' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1196:21: error: implicit declaration of function 'add192' [-Werror=implicit-function-declaration] 1196 | add192(remsig0, remsig1, remsig2, 0, dsig0, dsig1, | ^~ /tmp/qemu-test/src/target/i386/fpu_helper.c:1196:21: error: nested extern declaration of 'add192' [-Werror=nested-externs] /tmp/qemu-test/src/target/i386/fpu_helper.c:1211:17: error: implicit declaration of function 'mul128To256' [-Werror=implicit-function-declaration] 1211 | mul128To256(zsig0, zsig1, zsig0, zsig1, | ^~~ /tmp/qemu-test/src/target/i386/fpu_helper.c:1211:17: error: nested extern declaration of 'mul128To256' [-Werror=nested-externs] cc1: all warnings being treated as errors make[1]: *** [/tmp/qemu-test/src/rules.mak:69: target/i386/fpu_helper.o] Error 1
