Re: [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN.

2020-06-30 Thread Stefan Hajnoczi
On Mon, Jun 29, 2020 at 05:04:19PM +0100, Alex Bennée wrote:
> 
> Stefan Hajnoczi  writes:
> 
> > On Fri, Jun 26, 2020 at 01:00:01PM -0400, Robert Foley wrote:
> >> This is a cleanup patch to follow-up the patch which introduced TSAN.
> >> This patch makes separate start_switch_fiber_ functions for TSAN and ASAN.
> >> 
> >> This does two things:
> >> 1. Unrelated ASAN and TSAN code is separate and each function only
> >>has arguments that are actually needed.
> >> 2. The co->tsan_caller_fiber and co->tsan_co_fiber fields are only
> >>access from within #ifdef CONFIG_TSAN.
> >> 
> >> Signed-off-by: Robert Foley 
> >> ---
> >>  util/coroutine-ucontext.c | 52 +--
> >>  1 file changed, 34 insertions(+), 18 deletions(-)
> >
> > Thank you for revisiting this patch after it was applied!
> >
> > Reviewed-by: Stefan Hajnoczi 
> 
> Who takes care of coroutine patches or should this go via a different
> tree?

Commit 0aebab04b9289bd37017593b413ce7a762b54c55 ("configure: add
--enable-tsan flag + fiber annotations for coroutine-ucontext") went
through your tree. Please take this follow-up patch too.

Stefan


signature.asc
Description: PGP signature


Re: [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN.

2020-06-29 Thread Alex Bennée


Stefan Hajnoczi  writes:

> On Fri, Jun 26, 2020 at 01:00:01PM -0400, Robert Foley wrote:
>> This is a cleanup patch to follow-up the patch which introduced TSAN.
>> This patch makes separate start_switch_fiber_ functions for TSAN and ASAN.
>> 
>> This does two things:
>> 1. Unrelated ASAN and TSAN code is separate and each function only
>>has arguments that are actually needed.
>> 2. The co->tsan_caller_fiber and co->tsan_co_fiber fields are only
>>access from within #ifdef CONFIG_TSAN.
>> 
>> Signed-off-by: Robert Foley 
>> ---
>>  util/coroutine-ucontext.c | 52 +--
>>  1 file changed, 34 insertions(+), 18 deletions(-)
>
> Thank you for revisiting this patch after it was applied!
>
> Reviewed-by: Stefan Hajnoczi 

Who takes care of coroutine patches or should this go via a different
tree?

-- 
Alex Bennée



Re: [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN.

2020-06-29 Thread Stefan Hajnoczi
On Fri, Jun 26, 2020 at 01:00:01PM -0400, Robert Foley wrote:
> This is a cleanup patch to follow-up the patch which introduced TSAN.
> This patch makes separate start_switch_fiber_ functions for TSAN and ASAN.
> 
> This does two things:
> 1. Unrelated ASAN and TSAN code is separate and each function only
>has arguments that are actually needed.
> 2. The co->tsan_caller_fiber and co->tsan_co_fiber fields are only
>access from within #ifdef CONFIG_TSAN.
> 
> Signed-off-by: Robert Foley 
> ---
>  util/coroutine-ucontext.c | 52 +--
>  1 file changed, 34 insertions(+), 18 deletions(-)

Thank you for revisiting this patch after it was applied!

Reviewed-by: Stefan Hajnoczi 


signature.asc
Description: PGP signature