Re: [PATCH-for-9.0 18/25] util/oslib: Have qemu_prealloc_mem() handler return a boolean

2023-12-03 Thread Gavin Shan 

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote:

Following the example documented since commit e3fe3988d7 ("error:
Document Error API usage rules"), have cpu_exec_realizefn()
return a boolean indicating whether an error is set or not.

Signed-off-by: Philippe Mathieu-Daudé 
---
  include/qemu/osdep.h | 4 +++-
  util/oslib-posix.c   | 7 +--
  util/oslib-win32.c   | 4 +++-
  3 files changed, 11 insertions(+), 4 deletions(-)



s/cpu_exec_realizefn()/qemu_prealloc_mem()

Reviewed-by: Gavin Shan

Re: [PATCH-for-9.0 18/25] util/oslib: Have qemu_prealloc_mem() handler return a boolean

2023-11-21 Thread Peter Xu 
On Mon, Nov 20, 2023 at 10:32:52PM +0100, Philippe Mathieu-Daudé wrote:
> Following the example documented since commit e3fe3988d7 ("error:
> Document Error API usage rules"), have cpu_exec_realizefn()
> return a boolean indicating whether an error is set or not.
> 
> Signed-off-by: Philippe Mathieu-Daudé 

Reviewed-by: Peter Xu 

-- 
Peter Xu