Re: [PATCH-for-9.0 21/25] hw/arm: Simplify memory_region_init_rom() calls

2023-12-03 Thread Gavin Shan 

On 11/21/23 07:32, Philippe Mathieu-Daudé wrote:

Mechanical change using the following coccinelle script:

@@
expression mr, owner, arg3, arg4, errp;
@@
-   memory_region_init_rom(mr, owner, arg3, arg4, );
 if (
-   errp
+   !memory_region_init_rom(mr, owner, arg3, arg4, )
 ) {
 ...
 return;
 }

and removing the local Error variable.

Signed-off-by: Philippe Mathieu-Daudé 
---
  hw/arm/fsl-imx25.c | 13 -
  hw/arm/fsl-imx31.c | 13 -
  hw/arm/fsl-imx6.c  | 13 -
  3 files changed, 12 insertions(+), 27 deletions(-)



Reviewed-by: Gavin Shan

Re: [PATCH-for-9.0 21/25] hw/arm: Simplify memory_region_init_rom() calls

2023-11-21 Thread Manos Pitsidianakis 

On Mon, 20 Nov 2023 23:32, Philippe Mathieu-Daudé  wrote:

Mechanical change using the following coccinelle script:

@@
expression mr, owner, arg3, arg4, errp;
@@
-   memory_region_init_rom(mr, owner, arg3, arg4, );
   if (
-   errp
+   !memory_region_init_rom(mr, owner, arg3, arg4, )
   ) {
   ...
   return;
   }

and removing the local Error variable.

Signed-off-by: Philippe Mathieu-Daudé 
---



Reviewed-by: Manos Pitsidianakis