Re: [PATCH-for-9.1 v2 0/4] hw/ssi/pnv_spi: Fixes Coverity CID 1558831

2024-11-04 Thread Philippe Mathieu-Daudé

On 4/11/24 02:51, Nicholas Piggin wrote:

On Thu Aug 8, 2024 at 6:28 AM AEST, Philippe Mathieu-Daudé wrote:

v2:
- Cover PowerNV SSI in MAINTAINERS
- Use GLib API in pnv_spi_xfer_buffer_free()
- Simplify returning early

Supersedes: <20240806134829.351703-3-chalapath...@linux.ibm.com>

Chalapathi V (1):
   hw/ssi/pnv_spi: Fixes Coverity CID 1558831

Philippe Mathieu-Daudé (3):
   MAINTAINERS: Cover PowerPC SPI model in PowerNV section
   hw/ssi/pnv_spi: Match _xfer_buffer_free() with _xfer_buffer_new()
   hw/ssi/pnv_spi: Return early in transfer()


Note that I included this series in the ppc 9.2 PR, because Chalapathi
has not found time to finish the better rework. There were a couple
of comments about style / unnecessary code for these, but that will
all get replaced by the rework so I prefer to leave unchanged. Thanks
all for the help with this.


Thanks Nick!




Re: [PATCH-for-9.1 v2 0/4] hw/ssi/pnv_spi: Fixes Coverity CID 1558831

2024-11-03 Thread Nicholas Piggin
On Thu Aug 8, 2024 at 6:28 AM AEST, Philippe Mathieu-Daudé wrote:
> v2:
> - Cover PowerNV SSI in MAINTAINERS
> - Use GLib API in pnv_spi_xfer_buffer_free()
> - Simplify returning early
>
> Supersedes: <20240806134829.351703-3-chalapath...@linux.ibm.com>
>
> Chalapathi V (1):
>   hw/ssi/pnv_spi: Fixes Coverity CID 1558831
>
> Philippe Mathieu-Daudé (3):
>   MAINTAINERS: Cover PowerPC SPI model in PowerNV section
>   hw/ssi/pnv_spi: Match _xfer_buffer_free() with _xfer_buffer_new()
>   hw/ssi/pnv_spi: Return early in transfer()

Note that I included this series in the ppc 9.2 PR, because Chalapathi
has not found time to finish the better rework. There were a couple
of comments about style / unnecessary code for these, but that will
all get replaced by the rework so I prefer to leave unchanged. Thanks
all for the help with this.

Thanks,
Nick



Re: [PATCH-for-9.1 v2 0/4] hw/ssi/pnv_spi: Fixes Coverity CID 1558831

2024-09-16 Thread Chalapathi V



On 13-09-2024 19:07, Cédric Le Goater wrote:

Hello,

On 9/13/24 15:24, Chalapathi V wrote:


On 12-09-2024 22:25, Cédric Le Goater wrote:

Chalapthi,

On 8/7/24 22:28, Philippe Mathieu-Daudé wrote:

v2:
- Cover PowerNV SSI in MAINTAINERS
- Use GLib API in pnv_spi_xfer_buffer_free()
- Simplify returning early

Supersedes: <20240806134829.351703-3-chalapath...@linux.ibm.com>


I was wondering where we were on this series. I see there were comments
on the initial one that would need some response at least. Do you have
plans for a respin ?

Thanks,

C.


Hello Cedric,

Thank You so much for reminding me. I apologize for not getting back 
on this sooner. 


That's fine. We have some spare time before the QEMU 9.2 cycle
closes. I'd say ~2 months. Still, it would be good to address
these issues before adding more models (Dan's TPM device model)
relying on it.

Sure. Thank You.


I am working on the review comments from initial v1 patchset and send 
the v2 patchset ASAP.


That would be a v3 ? Since Philippe sent a v2.

Thanks,

C.
Sure. Will send v3 for the series: hw/ssi/pnv_spi: Fixes Coverity CID 
1558831 and


a separate series for resolving Coverity CID 1558827.

Thank You,

Chalapathi




Re: [PATCH-for-9.1 v2 0/4] hw/ssi/pnv_spi: Fixes Coverity CID 1558831

2024-09-13 Thread Cédric Le Goater

Hello,

On 9/13/24 15:24, Chalapathi V wrote:


On 12-09-2024 22:25, Cédric Le Goater wrote:

Chalapthi,

On 8/7/24 22:28, Philippe Mathieu-Daudé wrote:

v2:
- Cover PowerNV SSI in MAINTAINERS
- Use GLib API in pnv_spi_xfer_buffer_free()
- Simplify returning early

Supersedes: <20240806134829.351703-3-chalapath...@linux.ibm.com>


I was wondering where we were on this series. I see there were comments
on the initial one that would need some response at least. Do you have
plans for a respin ?

Thanks,

C.


Hello Cedric,

Thank You so much for reminding me. I apologize for not getting back on this sooner. 


That's fine. We have some spare time before the QEMU 9.2 cycle
closes. I'd say ~2 months. Still, it would be good to address
these issues before adding more models (Dan's TPM device model)
relying on it.


I am working on the review comments from initial v1 patchset and send the v2 
patchset ASAP.


That would be a v3 ? Since Philippe sent a v2.

Thanks,

C.




Re: [PATCH-for-9.1 v2 0/4] hw/ssi/pnv_spi: Fixes Coverity CID 1558831

2024-09-13 Thread Chalapathi V



On 12-09-2024 22:25, Cédric Le Goater wrote:

Chalapthi,

On 8/7/24 22:28, Philippe Mathieu-Daudé wrote:

v2:
- Cover PowerNV SSI in MAINTAINERS
- Use GLib API in pnv_spi_xfer_buffer_free()
- Simplify returning early

Supersedes: <20240806134829.351703-3-chalapath...@linux.ibm.com>


I was wondering where we were on this series. I see there were comments
on the initial one that would need some response at least. Do you have
plans for a respin ?

Thanks,

C.


Hello Cedric,

Thank You so much for reminding me. I apologize for not getting back on 
this sooner. I am working on the review comments from initial v1 
patchset and send the v2 patchset ASAP.


Thank You,

Chalapathi



Chalapathi V (1):
   hw/ssi/pnv_spi: Fixes Coverity CID 1558831

Philippe Mathieu-Daudé (3):
   MAINTAINERS: Cover PowerPC SPI model in PowerNV section
   hw/ssi/pnv_spi: Match _xfer_buffer_free() with _xfer_buffer_new()
   hw/ssi/pnv_spi: Return early in transfer()

  MAINTAINERS  |  2 ++
  hw/ssi/pnv_spi.c | 12 +++-
  2 files changed, 9 insertions(+), 5 deletions(-)








Re: [PATCH-for-9.1 v2 0/4] hw/ssi/pnv_spi: Fixes Coverity CID 1558831

2024-09-12 Thread Cédric Le Goater

Chalapthi,

On 8/7/24 22:28, Philippe Mathieu-Daudé wrote:

v2:
- Cover PowerNV SSI in MAINTAINERS
- Use GLib API in pnv_spi_xfer_buffer_free()
- Simplify returning early

Supersedes: <20240806134829.351703-3-chalapath...@linux.ibm.com>


I was wondering where we were on this series. I see there were comments
on the initial one that would need some response at least. Do you have
plans for a respin ?

Thanks,

C.



Chalapathi V (1):
   hw/ssi/pnv_spi: Fixes Coverity CID 1558831

Philippe Mathieu-Daudé (3):
   MAINTAINERS: Cover PowerPC SPI model in PowerNV section
   hw/ssi/pnv_spi: Match _xfer_buffer_free() with _xfer_buffer_new()
   hw/ssi/pnv_spi: Return early in transfer()

  MAINTAINERS  |  2 ++
  hw/ssi/pnv_spi.c | 12 +++-
  2 files changed, 9 insertions(+), 5 deletions(-)