On Mon, 18 May 2020 at 06:04, Markus Armbruster <arm...@redhat.com> wrote: > > pxa2xx_mmci_init() creates a "pxa2xx-mmci" device, but neglects to > realize it. Affects machines akita, borzoi, connex, mainstone, spitz, > terrier, tosa, verdex, and z2. > > I wonder how this ever worked. If the "device becomes real only on > realize" thing actually works, then we've always been missing the > device, yet nobody noticed.
It works by accident: because the device in question happens to not have a realize method, nothing breaks if we forget to run the realize method. Undefined behaviour: we happened to get lucky in this case. Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM