Re: [PATCH 1/5] hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus()

2020-07-13 Thread Cédric Le Goater
On 6/29/20 7:38 PM, Philippe Mathieu-Daudé wrote: > Simplify aspeed_i2c_get_bus() by using a AspeedI2CState argument. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater > --- > include/hw/i2c/aspeed_i2c.h | 2 +- > hw/arm/aspeed.c | 70

Re: [PATCH 1/5] hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus()

2020-06-30 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Simplify aspeed_i2c_get_bus() by using a AspeedI2CState argument. > > Signed-off-by: Philippe Mathieu-Daudé The real motivation seems to be simplifying the callers: every single one of them casts the argument from AspeedI2CState * to DeviceState *. Pointing