On Tue, Jan 14, 2020 at 2:56 AM Alex Bennée wrote:
> Could we cut out the middle-man and just qemu_add_log(LOG_STRACE) here
> and drop the enable_strace variable.
This code has been re-factored based on Laurent's comments. In v2
`enable_strace` is still needed to avoid QEMU_LOG/-d overwriting
On Tue, Jan 14, 2020 at 1:09 AM Laurent Vivier wrote:
> This is really a special case as the flags are all given at the same
> time, could you use directly qemu_set_log() in main()?
Fixed in v2.
> > +/* Remove (subtract) the given log flags from the current log mask. */
> > +static inline void
On 14/01/20 10:09, Laurent Vivier wrote:
> Perhaps we can use flag LOG_TRACE? (cc Paolo)
No, LOG_TRACE is for trace-events tracepoints. A new logging flag is
definitely the way to go.
Paolo
Josh Kunz writes:
> This change switches linux-user strace logging to use the newer `qemu_log`
> logging subsystem rather than the older `gemu_log` (notice the "g")
> logger. `qemu_log` has several advantages, namely that it allows logging
> to a file, and provides a more unified interface for
Le 14/01/2020 à 04:01, Josh Kunz a écrit :
> This change switches linux-user strace logging to use the newer `qemu_log`
> logging subsystem rather than the older `gemu_log` (notice the "g")
> logger. `qemu_log` has several advantages, namely that it allows logging
> to a file, and provides a more
