Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-11 Thread Laszlo Ersek
On 10/11/19 08:50, Laszlo Ersek wrote: > On 10/10/19 20:08, Michael S. Tsirkin wrote: >> On Thu, Oct 10, 2019 at 06:23:00PM +0200, Laszlo Ersek wrote: >>> On 10/10/19 14:48, Igor Mammedov wrote: >>> it doesn't really matter if it's ACPI blob or fw_cfg, what firmware needs is a table of

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-11 Thread Laszlo Ersek
On 10/10/19 20:08, Michael S. Tsirkin wrote: > On Thu, Oct 10, 2019 at 06:23:00PM +0200, Laszlo Ersek wrote: >> On 10/10/19 14:48, Igor Mammedov wrote: >> >>> it doesn't really matter if it's ACPI blob or fw_cfg, >>> what firmware needs is a table of possible CPUs with APIC IDs. >> >> To repeat my

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2019 at 06:23:00PM +0200, Laszlo Ersek wrote: > On 10/10/19 14:48, Igor Mammedov wrote: > > > it doesn't really matter if it's ACPI blob or fw_cfg, > > what firmware needs is a table of possible CPUs with APIC IDs. > > To repeat my previous point: > > Not necessarily taking

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Laszlo Ersek
On 10/10/19 14:48, Igor Mammedov wrote: > it doesn't really matter if it's ACPI blob or fw_cfg, > what firmware needs is a table of possible CPUs with APIC IDs. To repeat my previous point: Not necessarily taking sides between "data table" and "register block", but *if* we opt for "data table",

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Laszlo Ersek
On 10/10/19 12:01, Michael S. Tsirkin wrote: > On Tue, Oct 08, 2019 at 05:59:31PM +0200, Igor Mammedov wrote: >> So far there were no need for it as all possible cpus are >> described in ACPI tables passed to guest, but I'm not going >> to suggest to parse them on firmware side as it's too

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Igor Mammedov
On Thu, 10 Oct 2019 06:01:51 -0400 "Michael S. Tsirkin" wrote: > On Tue, Oct 08, 2019 at 05:59:31PM +0200, Igor Mammedov wrote: > > On Tue, 8 Oct 2019 12:52:58 +0200 > > Laszlo Ersek wrote: > > > > > FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, > > > due to

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Michael S. Tsirkin
On Tue, Oct 08, 2019 at 05:59:31PM +0200, Igor Mammedov wrote: > On Tue, 8 Oct 2019 12:52:58 +0200 > Laszlo Ersek wrote: > > > FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, > > due to historical reasons. That value is not useful to edk2, however. For > > supporting

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Igor Mammedov
On Wed, 9 Oct 2019 23:01:21 +0200 Laszlo Ersek wrote: > On 10/08/19 17:59, Igor Mammedov wrote: > > On Tue, 8 Oct 2019 12:52:58 +0200 > > Laszlo Ersek wrote: > > > >> FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, > >> due to historical reasons. That value is not

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-09 Thread Laszlo Ersek
On 10/08/19 17:59, Igor Mammedov wrote: > On Tue, 8 Oct 2019 12:52:58 +0200 > Laszlo Ersek wrote: > >> FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, >> due to historical reasons. That value is not useful to edk2, however. For >> supporting VCPU hotplug, edk2 needs:

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-09 Thread Eduardo Habkost
On Tue, Oct 08, 2019 at 08:58:30PM +0200, Laszlo Ersek wrote: > Eduardo, Igor, > > On 10/08/19 12:52, Laszlo Ersek wrote: > > FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, > > due to historical reasons. That value is not useful to edk2, however. For > > supporting

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-09 Thread Laszlo Ersek
On 10/09/19 13:13, Igor Mammedov wrote: > On Tue, 8 Oct 2019 20:58:30 +0200 > Laszlo Ersek wrote: > >> Eduardo, Igor, >> >> On 10/08/19 12:52, Laszlo Ersek wrote: >>> FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, >>> due to historical reasons. That value is not

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-09 Thread Igor Mammedov
On Tue, 8 Oct 2019 20:58:30 +0200 Laszlo Ersek wrote: > Eduardo, Igor, > > On 10/08/19 12:52, Laszlo Ersek wrote: > > FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, > > due to historical reasons. That value is not useful to edk2, however. For > > supporting VCPU

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-08 Thread Laszlo Ersek
Eduardo, Igor, On 10/08/19 12:52, Laszlo Ersek wrote: > FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, > due to historical reasons. That value is not useful to edk2, however. For > supporting VCPU hotplug, edk2 needs: > > - the boot CPU count (already exposed in

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-08 Thread Laszlo Ersek
On 10/08/19 15:29, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 10/8/19 12:52 PM, Laszlo Ersek wrote: >> FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest >> firmware, >> due to historical reasons. That value is not useful to edk2, however. For >> supporting VCPU hotplug, edk2

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-08 Thread Igor Mammedov
On Tue, 8 Oct 2019 12:52:58 +0200 Laszlo Ersek wrote: > FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, > due to historical reasons. That value is not useful to edk2, however. For > supporting VCPU hotplug, edk2 needs: > > - the boot CPU count (already exposed in

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-08 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 10/8/19 12:52 PM, Laszlo Ersek wrote: FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, due to historical reasons. That value is not useful to edk2, however. For supporting VCPU hotplug, edk2 needs: - the boot CPU count (already exposed in