Re: [PATCH 3/4] migration/multifd: initialize packet->magic/version once at setup stage

2019-10-11 Thread Wei Yang
On Fri, Oct 11, 2019 at 12:20:48PM +0200, Juan Quintela wrote:
>Wei Yang  wrote:
>> MultiFDPacket_t's magic and version field never changes during
>> migration, so move these two fields in setup stage.
>>
>> Signed-off-by: Wei Yang 
>
>Reviewed-by: Juan Quintela 
>
>It don't really matter, and is faster your way O:-)

You are right.

And I am wondering one more thing. Why we need to carry magic/version for each
packet? Would it be better to just carry and check magic/version for the
initial packet only?

-- 
Wei Yang
Help you, Help me



Re: [PATCH 3/4] migration/multifd: initialize packet->magic/version once at setup stage

2019-10-11 Thread Juan Quintela
Wei Yang  wrote:
> MultiFDPacket_t's magic and version field never changes during
> migration, so move these two fields in setup stage.
>
> Signed-off-by: Wei Yang 

Reviewed-by: Juan Quintela 

It don't really matter, and is faster your way O:-)