Re: [PATCH 7/7] target/riscv: Honour -semihosting-config userspace=on and enable=on

2022-08-19 Thread Peter Maydell
On Fri, 19 Aug 2022 at 01:55, Alistair Francis wrote: > > On Thu, Aug 18, 2022 at 11:58 PM Peter Maydell > wrote: > > Do you have an opinion on whether there are likely to be many > > users who are using riscv semihosting without explicitly enabling it > > on the command line ? > > I don't

Re: [PATCH 7/7] target/riscv: Honour -semihosting-config userspace=on and enable=on

2022-08-18 Thread Alistair Francis
On Thu, Aug 18, 2022 at 11:58 PM Peter Maydell wrote: > > On Thu, 18 Aug 2022 at 05:20, Alistair Francis wrote: > > > > On Tue, Aug 16, 2022 at 5:11 AM Peter Maydell > > wrote: > > > > > > The riscv target incorrectly enabled semihosting always, whether the > > > user asked for it or not.

Re: [PATCH 7/7] target/riscv: Honour -semihosting-config userspace=on and enable=on

2022-08-18 Thread Peter Maydell
On Thu, 18 Aug 2022 at 05:20, Alistair Francis wrote: > > On Tue, Aug 16, 2022 at 5:11 AM Peter Maydell > wrote: > > > > The riscv target incorrectly enabled semihosting always, whether the > > user asked for it or not. Call semihosting_enabled() passing the > > correct value to the

Re: [PATCH 7/7] target/riscv: Honour -semihosting-config userspace=on and enable=on

2022-08-17 Thread Alistair Francis
On Tue, Aug 16, 2022 at 5:11 AM Peter Maydell wrote: > > The riscv target incorrectly enabled semihosting always, whether the > user asked for it or not. Call semihosting_enabled() passing the > correct value to the is_userspace argument, which fixes this and also > handles the userspace=on

Re: [PATCH 7/7] target/riscv: Honour -semihosting-config userspace=on and enable=on

2022-08-15 Thread Furquan Shaikh
On Mon, Aug 15, 2022 at 1:26 PM Richard Henderson wrote: > > On 8/15/22 14:03, Peter Maydell wrote: > > The riscv target incorrectly enabled semihosting always, whether the > > user asked for it or not. Call semihosting_enabled() passing the > > correct value to the is_userspace argument, which

Re: [PATCH 7/7] target/riscv: Honour -semihosting-config userspace=on and enable=on

2022-08-15 Thread Richard Henderson
On 8/15/22 14:03, Peter Maydell wrote: The riscv target incorrectly enabled semihosting always, whether the user asked for it or not. Call semihosting_enabled() passing the correct value to the is_userspace argument, which fixes this and also handles the userspace=on argument. Note that this