Re: [PATCH RFC 02/28] ui/input: Remove QAPI wrappers from QemuInputEvent

2026-05-09 Thread Akihiko Odaki 

On 2026/05/10 15:01, [email protected] wrote:

On Sat, 09 May 2026 19:34:14 +0900, Akihiko Odaki 
 wrote:

Hi,



diff --git a/ui/input.c b/ui/input.c
index 52ab7beb942..a3ced08429e 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -159,16 +159,55 @@ void qmp_input_send_event(const char *device,
[ ... skip 30 lines ... ]
+g_assert_not_reached();
+}
+
+evt.key.key.type = KEY_VALUE_KIND_QCODE;
+evt.key.key.u.qcode.data = code;
+evt.key.key = *qapi->u.key.data->key;


You are overwriting the QCODE/code with this assignment. Swap the lines?



I will remove evt.key.key = *qapi->u.key.data->key. It is likely to be 
an artifact of rebase.


Regards,
Akihiko Odaki

Re: [PATCH RFC 02/28] ui/input: Remove QAPI wrappers from QemuInputEvent

2026-05-09 Thread marcandre . lureau 
On Sat, 09 May 2026 19:34:14 +0900, Akihiko Odaki 
 wrote:

Hi,

>
> diff --git a/ui/input.c b/ui/input.c
> index 52ab7beb942..a3ced08429e 100644
> --- a/ui/input.c
> +++ b/ui/input.c
> @@ -159,16 +159,55 @@ void qmp_input_send_event(const char *device,
> [ ... skip 30 lines ... ]
> +g_assert_not_reached();
> +}
> +
> +evt.key.key.type = KEY_VALUE_KIND_QCODE;
> +evt.key.key.u.qcode.data = code;
> +evt.key.key = *qapi->u.key.data->key;

You are overwriting the QCODE/code with this assignment. Swap the lines?

-- 
Marc-André Lureau