Re: [PATCH rc6 22/30] target/avr: Register AVR support with the rest of QEMU
On 06/07/2020 16.56, Eric Blake wrote: > On 7/5/20 9:03 AM, Thomas Huth wrote: >> From: Michael Rolnik >> >> Add AVR related definitions into QEMU. >> >> [AM: Remove word 'Atmel' from filenames and all elements of code] >> Suggested-by: Aleksandar Markovic >> Signed-off-by: Michael Rolnik >> Signed-off-by: Richard Henderson >> Signed-off-by: Aleksandar Markovic >> Tested-by: Philippe Mathieu-Daudé >> Reviewed-by: Aleksandar Markovic >> Signed-off-by: Thomas Huth >> --- > >> +++ b/qapi/machine.json >> @@ -25,7 +25,7 @@ >> # Since: 3.0 >> ## > > Missing a line that resembles: > > # @avr since 5.1 I thought that we stopped doing that ... but apparently, my memory was wrong and this was only about the "dropped" statements (see commit id bb5ccf225e81d2). Ok, I can add that again (though it's somewhat strange that we removed the "dropped" statements but still keep the "since" statements...?) Thomas
Re: [PATCH rc6 22/30] target/avr: Register AVR support with the rest of QEMU
On 7/5/20 9:03 AM, Thomas Huth wrote:
From: Michael Rolnik
Add AVR related definitions into QEMU.
[AM: Remove word 'Atmel' from filenames and all elements of code]
Suggested-by: Aleksandar Markovic
Signed-off-by: Michael Rolnik
Signed-off-by: Richard Henderson
Signed-off-by: Aleksandar Markovic
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Aleksandar Markovic
Signed-off-by: Thomas Huth
---
+++ b/qapi/machine.json
@@ -25,7 +25,7 @@
# Since: 3.0
##
Missing a line that resembles:
# @avr since 5.1
{ 'enum' : 'SysEmuTarget',
- 'data' : [ 'aarch64', 'alpha', 'arm', 'cris', 'hppa', 'i386', 'lm32',
+ 'data' : [ 'aarch64', 'alpha', 'arm', 'avr', 'cris', 'hppa', 'i386', 'lm32',
'm68k', 'microblaze', 'microblazeel', 'mips', 'mips64',
'mips64el', 'mipsel', 'moxie', 'nios2', 'or1k', 'ppc',
'ppc64', 'riscv32', 'riscv64', 'rx', 's390x', 'sh4',
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
