Re: [PATCH v1 2/4] Acceptance test: EXEC migration

2020-02-20 Thread Wainer dos Santos Moschetta 



On 2/14/20 12:52 PM, Oksana Vohchana wrote:

Improves EXEC migration to run whole test stage

Signed-off-by: Oksana Vohchana 
---
  tests/acceptance/migration.py | 2 ++
  1 file changed, 2 insertions(+)


Indeed, with this changes the migration is triggered.

Tested-by: Wainer dos Santos Moschetta 



diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
index e4c39b85a1..8209dcf71d 100644
--- a/tests/acceptance/migration.py
+++ b/tests/acceptance/migration.py
@@ -75,3 +75,5 @@ class Migration(Test):
  """
  free_port = self._get_free_port()
  dest_uri = 'exec:nc -l localhost %u' % free_port
+src_uri = 'exec:nc localhost %u' % free_port
+self.do_migrate(dest_uri, src_uri)

Re: [PATCH v1 2/4] Acceptance test: EXEC migration

2020-02-14 Thread Philippe Mathieu-Daudé 

On 2/14/20 3:52 PM, Oksana Vohchana wrote:

Improves EXEC migration to run whole test stage

Signed-off-by: Oksana Vohchana 


Fixes: 2e768cb682bf


---
  tests/acceptance/migration.py | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
index e4c39b85a1..8209dcf71d 100644
--- a/tests/acceptance/migration.py
+++ b/tests/acceptance/migration.py
@@ -75,3 +75,5 @@ class Migration(Test):
  """
  free_port = self._get_free_port()
  dest_uri = 'exec:nc -l localhost %u' % free_port
+src_uri = 'exec:nc localhost %u' % free_port
+self.do_migrate(dest_uri, src_uri)



I was very surprised because commit 2e768cb682bf is not the content I 
reviewed. Apparently what happened here is you sent 2 different series 
with the same subject... I got confused while applying I selected the 
incorrect id:


$ pwclient list 'Acceptance test: provides to use different transport 
for migration'

ID  StateName
--  -
11348377 New  Acceptance test: provides to use different 
transport for migration
11348719 New  Acceptance test: provides to use different 
transport for migration
11355797 New  [v2] Acceptance test: provides to use different 
transport for migration
11358447 New  [v2,REPOST] Acceptance test: provides to use 
different transport for migration
11362397 New  [v3,1/2] Acceptance test: provides to use 
different transport for migration
11362399 New  [v3,2/2] Acceptance test: provides to use 
different transport for migration
11362479 New  [v3,1/2] Acceptance test: provides to use 
different transport for migration
11362485 New  [v3,2/2] Acceptance test: provides to use 
different transport for migration


I am sorry I missed that.

Reviewed-by: Philippe Mathieu-Daudé