On Sun, Apr 28, 2024 at 03:39:09PM +0300, Michael Tokarev wrote:
> 17.04.2024 05:56, Li Zhijian via wrote:
> > bdrv_activate_all() should not be called from the coroutine context, move
> > it to the QEMU thread colo_process_incoming_thread() with the bql_lock
> > protected.
> >
> > The backtrace
17.04.2024 05:56, Li Zhijian via wrote:
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -835,6 +835,16 @@ static void *colo_process_incoming_thread(void *opaque)
return NULL;
}
+/* Make sure all file formats throw away their mutable metadata */
+bql_lock();
+
17.04.2024 05:56, Li Zhijian via wrote:
bdrv_activate_all() should not be called from the coroutine context, move
it to the QEMU thread colo_process_incoming_thread() with the bql_lock
protected.
The backtrace is as follows:
#4 0x561af7948362 in bdrv_graph_rdlock_main_loop () at
On Wed, Apr 17, 2024 at 10:56:34AM +0800, Li Zhijian via wrote:
> bdrv_activate_all() should not be called from the coroutine context, move
> it to the QEMU thread colo_process_incoming_thread() with the bql_lock
> protected.
>
> The backtrace is as follows:
> #4 0x561af7948362 in
Li Zhijian via writes:
> bdrv_activate_all() should not be called from the coroutine context, move
> it to the QEMU thread colo_process_incoming_thread() with the bql_lock
> protected.
>
> The backtrace is as follows:
> #4 0x561af7948362 in bdrv_graph_rdlock_main_loop () at
>
On 17/04/2024 14:13, Philippe Mathieu-Daudé wrote:
> On 17/4/24 04:56, Li Zhijian via wrote:
>> bdrv_activate_all() should not be called from the coroutine context, move
>> it to the QEMU thread colo_process_incoming_thread() with the bql_lock
>> protected.
>>
>> The backtrace is as follows:
>>
: [PATCH v2] migration/colo: Fix bdrv_graph_rdlock_main_loop:
Assertion `!qemu_in_coroutine()' failed.
On 17/4/24 04:56, Li Zhijian via wrote:
bdrv_activate_all() should not be called from the coroutine context,
move it to the QEMU thread colo_process_incoming_thread() with the
bql_lock protected
> -Original Message-
> From: Philippe Mathieu-Daudé
> Sent: Wednesday, April 17, 2024 2:14 PM
> To: Li Zhijian ; Zhang, Hailiang
> ; pet...@redhat.com; faro...@suse.de
> Cc: qemu-devel@nongnu.org; Zhang, Chen ; Wen
> Congyang ; Xie Changlong
>
> Subject: Re
On 17/4/24 04:56, Li Zhijian via wrote:
bdrv_activate_all() should not be called from the coroutine context, move
it to the QEMU thread colo_process_incoming_thread() with the bql_lock
protected.
The backtrace is as follows:
#4 0x561af7948362 in bdrv_graph_rdlock_main_loop () at
