Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Dec 02, 2020 at 12:01:21PM +, Daniel P. Berrangé wrote: > On Wed, Dec 02, 2020 at 06:37:46AM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 11:26:39AM +, Daniel P. Berrangé wrote: > > > On Wed, Dec 02, 2020 at 06:19:29AM -0500, Michael S. Tsirkin wrote: > > > > On

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 12:16:24PM +, Daniel P. Berrangé wrote: > On Thu, Dec 03, 2020 at 07:11:17AM -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 03, 2020 at 11:43:41AM +, Dr. David Alan Gilbert wrote: > > > Another way to solve this would be to remove the unplugging from the > > >

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 07:11:17AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 03, 2020 at 11:43:41AM +, Dr. David Alan Gilbert wrote: > > Another way to solve this would be to remove the unplugging from the > > migration layer and leave it as a problem for the management layer to do > >

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 12:06:14PM +, Daniel P. Berrangé wrote: > > > It isn't really about the admin. It is about countless existing mgmt apps > > > that expect migration will always succeed if the VM is paused. The mgmt > > > apps triggering the migraiton is not neccessarily the same as

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 11:43:41AM +, Dr. David Alan Gilbert wrote: > Another way to solve this would be to remove the unplugging from the > migration layer and leave it as a problem for the management layer to do > the unplug. Daniel described the problem with modular management tools which

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 07:01:11AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 03, 2020 at 11:45:12AM +, Daniel P. Berrangé wrote: > > On Thu, Dec 03, 2020 at 06:40:11AM -0500, Michael S. Tsirkin wrote: > > > On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > > > > On

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Dec 03, 2020 at 11:43:41AM +, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > > > > On Thu, Dec 03, 2020 at 06:21:47AM -0500,

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 11:43:41AM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > > > On Thu, Dec 03, 2020 at 06:21:47AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Dec 02, 2020 at

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 11:45:12AM +, Daniel P. Berrangé wrote: > On Thu, Dec 03, 2020 at 06:40:11AM -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > > > On Thu, Dec 03, 2020 at 06:21:47AM -0500, Michael S. Tsirkin wrote: > > > > On

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 06:40:11AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > > On Thu, Dec 03, 2020 at 06:21:47AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 02, 2020 at 12:01:21PM +, Daniel P. Berrangé wrote: > > > > On

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > > On Thu, Dec 03, 2020 at 06:21:47AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 02, 2020 at 12:01:21PM +, Daniel P. Berrangé wrote: > > > > On Wed, Dec 02, 2020 at

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 11:32:53AM +, Daniel P. Berrangé wrote: > On Thu, Dec 03, 2020 at 06:21:47AM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 12:01:21PM +, Daniel P. Berrangé wrote: > > > On Wed, Dec 02, 2020 at 06:37:46AM -0500, Michael S. Tsirkin wrote: > > > > On

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Thu, Dec 03, 2020 at 06:21:47AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2020 at 12:01:21PM +, Daniel P. Berrangé wrote: > > On Wed, Dec 02, 2020 at 06:37:46AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 02, 2020 at 11:26:39AM +, Daniel P. Berrangé wrote: > > > > On

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Dec 02, 2020 at 12:01:21PM +, Daniel P. Berrangé wrote: > On Wed, Dec 02, 2020 at 06:37:46AM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 11:26:39AM +, Daniel P. Berrangé wrote: > > > On Wed, Dec 02, 2020 at 06:19:29AM -0500, Michael S. Tsirkin wrote: > > > > On

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Dec 02, 2020 at 06:37:46AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2020 at 11:26:39AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 02, 2020 at 06:19:29AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 02, 2020 at 10:55:15AM +, Daniel P. Berrangé wrote: > > > > On

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Dec 02, 2020 at 06:19:29AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2020 at 10:55:15AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 02, 2020 at 11:51:05AM +0100, Juan Quintela wrote: > > > "Michael S. Tsirkin" wrote: > > > > On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

"Michael S. Tsirkin" wrote: > On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S. Tsirkin wrote: >> On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote: >> > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote: >> > > On Wed, Nov 18, 2020 at 09:37:22AM +0100,

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Dec 02, 2020 at 11:26:39AM +, Daniel P. Berrangé wrote: > On Wed, Dec 02, 2020 at 06:19:29AM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 10:55:15AM +, Daniel P. Berrangé wrote: > > > On Wed, Dec 02, 2020 at 11:51:05AM +0100, Juan Quintela wrote: > > > > "Michael S.

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote: > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote: > > On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote: > > > If we have a paused guest, it can't unplug the network VF device, so > > > we wait

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Dec 02, 2020 at 10:55:15AM +, Daniel P. Berrangé wrote: > On Wed, Dec 02, 2020 at 11:51:05AM +0100, Juan Quintela wrote: > > "Michael S. Tsirkin" wrote: > > > On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S. Tsirkin wrote: > > >> On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P.

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Dec 02, 2020 at 05:31:50AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote: > > > > If we have

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote: > > > > If we have

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote: > On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote: > > If we have a paused guest, it can't unplug the network VF device, so > > we wait there forever. Just change the code to give one error on that > > case. > > >

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Dec 02, 2020 at 11:51:05AM +0100, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S. Tsirkin wrote: > >> On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote: > >> > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote: > If we have a paused guest, it can't unplug the network VF device, so > we wait there forever. Just change the code to give one error on that > case. > > Signed-off-by: Juan Quintela It's certainly possible but it's management

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

* Juan Quintela (quint...@redhat.com) wrote: > If we have a paused guest, it can't unplug the network VF device, so > we wait there forever. Just change the code to give one error on that > case. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- >