Re: [PATCH v2 1/2] migration: rework migrate_set_error() to migrate_report_err()

2024-04-25 Thread Vladimir Sementsov-Ogievskiy
On 25.04.24 00:52, Peter Xu wrote: On Wed, Apr 24, 2024 at 10:50:14PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 24.04.24 22:40, Peter Xu wrote: On Wed, Apr 24, 2024 at 08:42:44PM +0300, Vladimir Sementsov-Ogievskiy wrote: 1. Most of callers want to free the error after call. Let's help

Re: [PATCH v2 1/2] migration: rework migrate_set_error() to migrate_report_err()

2024-04-24 Thread Peter Xu
On Wed, Apr 24, 2024 at 10:50:14PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 24.04.24 22:40, Peter Xu wrote: > > On Wed, Apr 24, 2024 at 08:42:44PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > 1. Most of callers want to free the error after call. Let's help them. > > > > > > 2.

Re: [PATCH v2 1/2] migration: rework migrate_set_error() to migrate_report_err()

2024-04-24 Thread Vladimir Sementsov-Ogievskiy
On 24.04.24 22:40, Peter Xu wrote: On Wed, Apr 24, 2024 at 08:42:44PM +0300, Vladimir Sementsov-Ogievskiy wrote: 1. Most of callers want to free the error after call. Let's help them. 2. Some callers log the error, some not. We also have places where we log the stored error. Let's instead

Re: [PATCH v2 1/2] migration: rework migrate_set_error() to migrate_report_err()

2024-04-24 Thread Peter Xu
On Wed, Apr 24, 2024 at 08:42:44PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 1. Most of callers want to free the error after call. Let's help them. > > 2. Some callers log the error, some not. We also have places where we >log the stored error. Let's instead simply log every migration >