Re: [PATCH v2 1/3] target/arm: Remove PSTATE_SS from cpsr and move it into env->pstate.

2021-01-22 Thread Rebecca Cran
On 1/22/21 2:03 PM, Richard Henderson wrote: On 1/21/21 6:45 PM, Rebecca Cran wrote: cpsr_write(env, spsr, mask, CPSRWriteRaw); -if (!arm_singlestep_active(env)) { -env->uncached_cpsr &= ~PSTATE_SS; -} +env->pstate &= ~PSTATE_SS; Why are you

Re: [PATCH v2 1/3] target/arm: Remove PSTATE_SS from cpsr and move it into env->pstate.

2021-01-22 Thread Richard Henderson
On 1/21/21 6:45 PM, Rebecca Cran wrote: > cpsr has been treated as being the same as spsr, but it isn't. > Since PSTATE_SS isn't in cpsr, remove it and move it into env->pstate. > > Signed-off-by: Rebecca Cran > --- > target/arm/helper-a64.c | 4 +--- > target/arm/helper.c | 4 ++-- >