Re: [PATCH v2 16/30] qapi: Add blank lines before bulleted lists
Peter Maydell writes: > On Fri, 14 Feb 2020 at 16:02, Markus Armbruster wrote: >> >> Markus Armbruster writes: >> >> > Peter Maydell writes: >> > >> >> rST insists on a blank line before and after a bulleted list, >> >> but our texinfo doc generator did not. Add some extra blank >> >> lines in the doc comments so they're acceptable rST input. >> >> >> >> Signed-off-by: Peter Maydell >> >> Reviewed-by: Philippe Mathieu-Daudé >> > >> > Reviewed-by: Markus Armbruster >> >> Hmm, PATCH 06 appears to do the same, among other things. Sure you want >> this separate? > > Patch 6 is qga/; this is qapi/. D'oh! > This is again a product of my general preference for more > smaller patches rather than larger patches that touch more > files at once. Makes sense, thanks!
Re: [PATCH v2 16/30] qapi: Add blank lines before bulleted lists
On Fri, 14 Feb 2020 at 16:02, Markus Armbruster wrote: > > Markus Armbruster writes: > > > Peter Maydell writes: > > > >> rST insists on a blank line before and after a bulleted list, > >> but our texinfo doc generator did not. Add some extra blank > >> lines in the doc comments so they're acceptable rST input. > >> > >> Signed-off-by: Peter Maydell > >> Reviewed-by: Philippe Mathieu-Daudé > > > > Reviewed-by: Markus Armbruster > > Hmm, PATCH 06 appears to do the same, among other things. Sure you want > this separate? Patch 6 is qga/; this is qapi/. This is again a product of my general preference for more smaller patches rather than larger patches that touch more files at once. thanks -- PMM
Re: [PATCH v2 16/30] qapi: Add blank lines before bulleted lists
Markus Armbruster writes: > Peter Maydell writes: > >> rST insists on a blank line before and after a bulleted list, >> but our texinfo doc generator did not. Add some extra blank >> lines in the doc comments so they're acceptable rST input. >> >> Signed-off-by: Peter Maydell >> Reviewed-by: Philippe Mathieu-Daudé > > Reviewed-by: Markus Armbruster Hmm, PATCH 06 appears to do the same, among other things. Sure you want this separate?
Re: [PATCH v2 16/30] qapi: Add blank lines before bulleted lists
Peter Maydell writes: > rST insists on a blank line before and after a bulleted list, > but our texinfo doc generator did not. Add some extra blank > lines in the doc comments so they're acceptable rST input. > > Signed-off-by: Peter Maydell > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster
