Re: [PATCH v2 4/8] qapi/error: Change assertion

2021-04-17 Thread Markus Armbruster
John Snow writes: [...] > (Random aside on patch submission process: I do dislike how when I > change the topic of a commit, I lose out on git-backport-diff > functionality. I wish I had a persistent ID for commits that survived > beyond title changes. Sometimes I debate scripting adding some

Re: [PATCH v2 4/8] qapi/error: Change assertion

2021-04-16 Thread John Snow
On 4/16/21 2:17 AM, Markus Armbruster wrote: John Snow writes: On 4/15/21 3:00 AM, Markus Armbruster wrote: John Snow writes: On 3/30/21 1:18 PM, John Snow wrote: Realizing now that this commit topic is wrong :) A prior version modified the assertion, I decided it was less churn to

Re: [PATCH v2 4/8] qapi/error: Change assertion

2021-04-16 Thread Markus Armbruster
John Snow writes: > On 4/15/21 3:00 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 3/30/21 1:18 PM, John Snow wrote: >>> >>> Realizing now that this commit topic is wrong :) >>> >>> A prior version modified the assertion, I decided it was less churn to >>> simply add one. >>> >>>

Re: [PATCH v2 4/8] qapi/error: Change assertion

2021-04-15 Thread John Snow
On 4/15/21 3:00 AM, Markus Armbruster wrote: John Snow writes: On 3/30/21 1:18 PM, John Snow wrote: Realizing now that this commit topic is wrong :) A prior version modified the assertion, I decided it was less churn to simply add one. I think ideally we'd have no assertions here and we'd

Re: [PATCH v2 4/8] qapi/error: Change assertion

2021-04-15 Thread Markus Armbruster
John Snow writes: > On 3/30/21 1:18 PM, John Snow wrote: > > Realizing now that this commit topic is wrong :) > > A prior version modified the assertion, I decided it was less churn to > simply add one. > > I think ideally we'd have no assertions here and we'd rely on the type > hints, but I

Re: [PATCH v2 4/8] qapi/error: Change assertion

2021-04-08 Thread John Snow
On 3/30/21 1:18 PM, John Snow wrote: Realizing now that this commit topic is wrong :) A prior version modified the assertion, I decided it was less churn to simply add one. I think ideally we'd have no assertions here and we'd rely on the type hints, but I don't think I can prove that this