Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-22 Thread Cornelia Huck
On Thu, 22 Oct 2020 21:12:58 +0530 Kirti Wankhede wrote: > On 10/22/2020 1:21 PM, Cornelia Huck wrote: > > I'm a bit worried though that all that reasoning which flags are set or > > cleared when is quite complex, and it's easy to make mistakes. > > > > Can we model this as a FSM, where an

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-22 Thread Kirti Wankhede
On 10/22/2020 1:21 PM, Cornelia Huck wrote: On Wed, 21 Oct 2020 11:03:23 +0530 Kirti Wankhede wrote: On 10/20/2020 4:21 PM, Cornelia Huck wrote: On Sun, 18 Oct 2020 01:54:56 +0530 Kirti Wankhede wrote: On 9/29/2020 4:33 PM, Dr. David Alan Gilbert wrote: * Cornelia Huck

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-22 Thread Cornelia Huck
On Wed, 21 Oct 2020 11:03:23 +0530 Kirti Wankhede wrote: > On 10/20/2020 4:21 PM, Cornelia Huck wrote: > > On Sun, 18 Oct 2020 01:54:56 +0530 > > Kirti Wankhede wrote: > > > >> On 9/29/2020 4:33 PM, Dr. David Alan Gilbert wrote: > >>> * Cornelia Huck (coh...@redhat.com) wrote: > On

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-20 Thread Kirti Wankhede
On 10/20/2020 4:21 PM, Cornelia Huck wrote: On Sun, 18 Oct 2020 01:54:56 +0530 Kirti Wankhede wrote: On 9/29/2020 4:33 PM, Dr. David Alan Gilbert wrote: * Cornelia Huck (coh...@redhat.com) wrote: On Wed, 23 Sep 2020 04:54:07 +0530 Kirti Wankhede wrote: VM state change handler gets

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-20 Thread Cornelia Huck
On Sun, 18 Oct 2020 01:54:56 +0530 Kirti Wankhede wrote: > On 9/29/2020 4:33 PM, Dr. David Alan Gilbert wrote: > > * Cornelia Huck (coh...@redhat.com) wrote: > >> On Wed, 23 Sep 2020 04:54:07 +0530 > >> Kirti Wankhede wrote: > >> > >>> VM state change handler gets called on change in VM's

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-20 Thread Cornelia Huck
On Mon, 19 Oct 2020 11:51:36 -0600 Alex Williamson wrote: > On Sun, 18 Oct 2020 23:13:39 +0530 > Kirti Wankhede wrote: > > > > > > > +vfio_migration_set_state(char *name, uint32_t state) " (%s) state %d" > > +vfio_vmstate_change(char *name, int running, const char *reason, > >

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-19 Thread Alex Williamson
On Sun, 18 Oct 2020 23:13:39 +0530 Kirti Wankhede wrote: > > > +vfio_migration_set_state(char *name, uint32_t state) " (%s) state %d" > +vfio_vmstate_change(char *name, int running, const char *reason, > uint32_t dev_state) " (%s) running %d reason %s device state %d" >

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-18 Thread Kirti Wankhede
+vfio_migration_set_state(char *name, uint32_t state) " (%s) state %d" +vfio_vmstate_change(char *name, int running, const char *reason, uint32_t dev_state) " (%s) running %d reason %s device state %d" diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h index

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-17 Thread Alex Williamson
On Sun, 18 Oct 2020 02:00:44 +0530 Kirti Wankhede wrote: > On 9/26/2020 1:50 AM, Alex Williamson wrote: > > On Wed, 23 Sep 2020 04:54:07 +0530 > > Kirti Wankhede wrote: > > > >> VM state change handler gets called on change in VM's state. This is used > >> to set > >> VFIO device state to

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-17 Thread Kirti Wankhede
On 9/26/2020 1:50 AM, Alex Williamson wrote: On Wed, 23 Sep 2020 04:54:07 +0530 Kirti Wankhede wrote: VM state change handler gets called on change in VM's state. This is used to set VFIO device state to _RUNNING. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Dr. David

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-10-17 Thread Kirti Wankhede
On 9/29/2020 4:33 PM, Dr. David Alan Gilbert wrote: * Cornelia Huck (coh...@redhat.com) wrote: On Wed, 23 Sep 2020 04:54:07 +0530 Kirti Wankhede wrote: VM state change handler gets called on change in VM's state. This is used to set VFIO device state to _RUNNING. Signed-off-by: Kirti

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-09-29 Thread Dr. David Alan Gilbert
* Cornelia Huck (coh...@redhat.com) wrote: > On Wed, 23 Sep 2020 04:54:07 +0530 > Kirti Wankhede wrote: > > > VM state change handler gets called on change in VM's state. This is used > > to set > > VFIO device state to _RUNNING. > > > > Signed-off-by: Kirti Wankhede > > Reviewed-by: Neo Jia

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-09-25 Thread Alex Williamson
On Wed, 23 Sep 2020 04:54:07 +0530 Kirti Wankhede wrote: > VM state change handler gets called on change in VM's state. This is used to > set > VFIO device state to _RUNNING. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > Reviewed-by: Dr. David Alan Gilbert > --- >

Re: [PATCH v26 05/17] vfio: Add VM state change handler to know state of VM

2020-09-24 Thread Cornelia Huck
On Wed, 23 Sep 2020 04:54:07 +0530 Kirti Wankhede wrote: > VM state change handler gets called on change in VM's state. This is used to > set > VFIO device state to _RUNNING. > > Signed-off-by: Kirti Wankhede > Reviewed-by: Neo Jia > Reviewed-by: Dr. David Alan Gilbert > --- >