Re: [PATCH v3] hw/char/pl011: Enable TxFIFO and async transmission

2020-04-23 Thread Peter Maydell
On Wed, 11 Mar 2020 at 04:09, Gavin Shan wrote: > > The depth of TxFIFO can be 1 or 16 depending on LCR[4]. The TxFIFO is > disabled when its depth is 1. It's nice to have TxFIFO enabled if > possible because more characters can be piled and transmitted at once, > which would have less overhead.

Re: [PATCH v3] hw/char/pl011: Enable TxFIFO and async transmission

2020-03-25 Thread Peter Maydell
On Wed, 25 Mar 2020 at 15:56, Paolo Bonzini wrote: > > On 25/03/20 03:32, Gavin Shan wrote: > >> > > > > Marc-André, ping. Could you please review when you get a chance? Thanks in > > advance :) > > Or Peter; generally arch-specific changes (as opposed to fixes in > chardev API usage) are

Re: [PATCH v3] hw/char/pl011: Enable TxFIFO and async transmission

2020-03-25 Thread Paolo Bonzini
On 25/03/20 03:32, Gavin Shan wrote: >> > > Marc-André, ping. Could you please review when you get a chance? Thanks in > advance :) Or Peter; generally arch-specific changes (as opposed to fixes in chardev API usage) are generally reviewed by arch maintainers. Paolo

Re: [PATCH v3] hw/char/pl011: Enable TxFIFO and async transmission

2020-03-24 Thread Gavin Shan
On 3/11/20 3:09 PM, Gavin Shan wrote: The depth of TxFIFO can be 1 or 16 depending on LCR[4]. The TxFIFO is disabled when its depth is 1. It's nice to have TxFIFO enabled if possible because more characters can be piled and transmitted at once, which would have less overhead. Besides, we can be

Re: [PATCH v3] hw/char/pl011: Enable TxFIFO and async transmission

2020-03-11 Thread Gavin Shan
On 3/11/20 3:43 PM, no-re...@patchew.org wrote: [...] http://patchew.org/logs/20200311040923.29115-1-gs...@redhat.com/testing.asan/?type=message. Is it possible to be a false alarm? The detailed errors extracted from above link is shown as below, and I'm unable to reproduce it at local: Error

Re: [PATCH v3] hw/char/pl011: Enable TxFIFO and async transmission

2020-03-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200311040923.29115-1-gs...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export