Re: [PATCH v3 0/2] More virtio-snd fortifications/coverity fixes
On Wed, Jul 08, 2026 at 03:01:19PM +0300, Manos Pitsidianakis wrote: > On Wed, Jul 8, 2026 at 12:09 PM Michael Tokarev wrote: > > > > On 20.04.2026 08:07, Manos Pitsidianakis wrote: > > > Added checks for stuff coverity pointed out (CID 1547527). > > > > > > Signed-off-by: Manos Pitsidianakis > > > --- > > > Changes in v3: > > > - Added Coverity CID in patch message (thanks Alex) > > > - Link to v2: > > > https://lore.kernel.org/qemu-devel/[email protected] > > > > > > Changes in v2: > > > - Use g_size_checked_add (thanks rth) > > > - Link to v1: > > > https://lore.kernel.org/qemu-devel/[email protected] > > > > Hi! > > > > It looks like this patchset has been lost somehow. Is it still needed? > > > > /mjt > > Patch 2 is still unreviewed it seems. I might send a new series with > more patches soon. Thanks for the reminder! I think a bigger problem is that we allocate as much as guest wants in the 1st place. Want to look into this? > > > > > --- > > > Manos Pitsidianakis (2): > > >virtio-snd: check rx buffer descriptor size > > >virtio-snd: check for overflow before g_malloc0 > > > > > > hw/audio/virtio-snd.c | 24 +--- > > > 1 file changed, 17 insertions(+), 7 deletions(-) > > > --- > > > base-commit: da6c4fe60fee30dd77267764d55b38af9cb89d4b > > > change-id: 20260415-virtio-fixups-3bc3a1a1cd27 > > > > > > -- > > > γαῖα πυρί μιχθήτω > > > > > > > > > > -- > Manos Pitsidianakis > Emulation and Virtualization Engineer at Linaro Ltd
Re: [PATCH v3 0/2] More virtio-snd fortifications/coverity fixes
On Wed, Jul 08, 2026 at 03:01:19PM +0300, Manos Pitsidianakis wrote: > On Wed, Jul 8, 2026 at 12:09 PM Michael Tokarev wrote: > > > > On 20.04.2026 08:07, Manos Pitsidianakis wrote: > > > Added checks for stuff coverity pointed out (CID 1547527). > > > > > > Signed-off-by: Manos Pitsidianakis > > > --- > > > Changes in v3: > > > - Added Coverity CID in patch message (thanks Alex) > > > - Link to v2: > > > https://lore.kernel.org/qemu-devel/[email protected] > > > > > > Changes in v2: > > > - Use g_size_checked_add (thanks rth) > > > - Link to v1: > > > https://lore.kernel.org/qemu-devel/[email protected] > > > > Hi! > > > > It looks like this patchset has been lost somehow. Is it still needed? > > > > /mjt > > Patch 2 is still unreviewed it seems. I might send a new series with > more patches soon. Thanks for the reminder! so you will repost all this? > > > > > --- > > > Manos Pitsidianakis (2): > > >virtio-snd: check rx buffer descriptor size > > >virtio-snd: check for overflow before g_malloc0 > > > > > > hw/audio/virtio-snd.c | 24 +--- > > > 1 file changed, 17 insertions(+), 7 deletions(-) > > > --- > > > base-commit: da6c4fe60fee30dd77267764d55b38af9cb89d4b > > > change-id: 20260415-virtio-fixups-3bc3a1a1cd27 > > > > > > -- > > > γαῖα πυρί μιχθήτω > > > > > > > > > > -- > Manos Pitsidianakis > Emulation and Virtualization Engineer at Linaro Ltd
Re: [PATCH v3 0/2] More virtio-snd fortifications/coverity fixes
On Wed, Jul 8, 2026 at 12:09 PM Michael Tokarev wrote: > > On 20.04.2026 08:07, Manos Pitsidianakis wrote: > > Added checks for stuff coverity pointed out (CID 1547527). > > > > Signed-off-by: Manos Pitsidianakis > > --- > > Changes in v3: > > - Added Coverity CID in patch message (thanks Alex) > > - Link to v2: > > https://lore.kernel.org/qemu-devel/[email protected] > > > > Changes in v2: > > - Use g_size_checked_add (thanks rth) > > - Link to v1: > > https://lore.kernel.org/qemu-devel/[email protected] > > Hi! > > It looks like this patchset has been lost somehow. Is it still needed? > > /mjt Patch 2 is still unreviewed it seems. I might send a new series with more patches soon. Thanks for the reminder! > > > --- > > Manos Pitsidianakis (2): > >virtio-snd: check rx buffer descriptor size > >virtio-snd: check for overflow before g_malloc0 > > > > hw/audio/virtio-snd.c | 24 +--- > > 1 file changed, 17 insertions(+), 7 deletions(-) > > --- > > base-commit: da6c4fe60fee30dd77267764d55b38af9cb89d4b > > change-id: 20260415-virtio-fixups-3bc3a1a1cd27 > > > > -- > > γαῖα πυρί μιχθήτω > > > > > -- Manos Pitsidianakis Emulation and Virtualization Engineer at Linaro Ltd
Re: [PATCH v3 0/2] More virtio-snd fortifications/coverity fixes
On 20.04.2026 08:07, Manos Pitsidianakis wrote: Added checks for stuff coverity pointed out (CID 1547527). Signed-off-by: Manos Pitsidianakis --- Changes in v3: - Added Coverity CID in patch message (thanks Alex) - Link to v2: https://lore.kernel.org/qemu-devel/[email protected] Changes in v2: - Use g_size_checked_add (thanks rth) - Link to v1: https://lore.kernel.org/qemu-devel/[email protected] Hi! It looks like this patchset has been lost somehow. Is it still needed? /mjt --- Manos Pitsidianakis (2): virtio-snd: check rx buffer descriptor size virtio-snd: check for overflow before g_malloc0 hw/audio/virtio-snd.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) --- base-commit: da6c4fe60fee30dd77267764d55b38af9cb89d4b change-id: 20260415-virtio-fixups-3bc3a1a1cd27 -- γαῖα πυρί μιχθήτω
