Re: [PATCH v3 03/19] target/arm: Restrict DC-CVAP instruction to TCG accel

2020-04-17 Thread Peter Maydell
On Fri, 17 Apr 2020 at 15:19, Philippe Mathieu-Daudé wrote: > > On 4/17/20 3:54 PM, Peter Maydell wrote: > > Your suggested patch isn't quite the same as RTH's suggestion, > > because it puts the assert inside a stub probe_read() > > implementation rather than having the ifdef at the level > > of

Re: [PATCH v3 03/19] target/arm: Restrict DC-CVAP instruction to TCG accel

2020-04-17 Thread Philippe Mathieu-Daudé
On 4/17/20 3:54 PM, Peter Maydell wrote: On Fri, 17 Apr 2020 at 14:49, Philippe Mathieu-Daudé wrote: On 3/16/20 9:11 PM, Peter Maydell wrote: On Mon, 16 Mar 2020 at 19:36, Richard Henderson wrote: I'm not 100% sure how the system regs function under kvm. If they are not used at all, then

Re: [PATCH v3 03/19] target/arm: Restrict DC-CVAP instruction to TCG accel

2020-04-17 Thread Peter Maydell
On Fri, 17 Apr 2020 at 14:49, Philippe Mathieu-Daudé wrote: > > On 3/16/20 9:11 PM, Peter Maydell wrote: > > On Mon, 16 Mar 2020 at 19:36, Richard Henderson > > wrote: > >> I'm not 100% sure how the system regs function under kvm. > >> > >> If they are not used at all, then we should avoid them

Re: [PATCH v3 03/19] target/arm: Restrict DC-CVAP instruction to TCG accel

2020-04-17 Thread Philippe Mathieu-Daudé
On 3/16/20 9:11 PM, Peter Maydell wrote: On Mon, 16 Mar 2020 at 19:36, Richard Henderson wrote: I'm not 100% sure how the system regs function under kvm. If they are not used at all, then we should avoid them all en masse an not piecemeal like this. If they are used for something, then we

Re: [PATCH v3 03/19] target/arm: Restrict DC-CVAP instruction to TCG accel

2020-03-16 Thread Peter Maydell
On Mon, 16 Mar 2020 at 19:36, Richard Henderson wrote: > I'm not 100% sure how the system regs function under kvm. > > If they are not used at all, then we should avoid them all en masse an not > piecemeal like this. > > If they are used for something, then we should keep them registered and

Re: [PATCH v3 03/19] target/arm: Restrict DC-CVAP instruction to TCG accel

2020-03-16 Thread Richard Henderson
On 3/16/20 9:06 AM, Philippe Mathieu-Daudé wrote: > Under KVM the 'Data or unified Cache line Clean by VA to PoP' > instruction will trap. > > Fixes: 0d57b4999 ("Add support for DC CVAP & DC CVADP ins") > Signed-off-by: Philippe Mathieu-Daudé > --- > target/arm/helper.c | 12 ++-- > 1